lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-24 07:26:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't force BDA on memory allocs that will be used with dedicated images

Browse Source
This commit is contained in:
baldurk
2025-04-07 16:53:25 +01:00
parent af0a32db38
commit 4b561b81bb
1 changed files with 21 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/wrappers/vk_resource_funcs.cpp
+21 -11
View File
@@ -514,19 +514,29 @@ VkResult WrappedVulkan::vkAllocateMemory(VkDevice device, const VkMemoryAllocate
// will be bound against since there's no requirement for the buffer to be marked as BDA. This
// means that when RT is enabled ALL MEMORY IN THE ENTIRE PROGRAM must be marked as BDA just in
// case.
//
// we don't force this on for memory allocations that are going to be used for dedicated images
bool forceBDA = false;
if(IsCaptureMode(m_State) && AccelerationStructures())
{
// force BDA flag when creating, by adding the struct if needed
if(memFlags)
VkMemoryDedicatedAllocateInfo *dedicated = (VkMemoryDedicatedAllocateInfo *)FindNextStruct(
pAllocateInfo, VK_STRUCTURE_TYPE_MEMORY_DEDICATED_ALLOCATE_INFO);
if(dedicated == NULL || dedicated->image == VK_NULL_HANDLE)
{
memFlags->flags |= VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT;
}
else
{
rtForcedFlags.flags = VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT |
VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT;
rtForcedFlags.pNext = unwrapped.pNext;
unwrapped.pNext = &rtForcedFlags;
// force BDA flag when creating, by adding the struct if needed
forceBDA = true;
if(memFlags)
{
memFlags->flags |= VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT;
}
else
{
rtForcedFlags.flags = VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_BIT |
VK_MEMORY_ALLOCATE_DEVICE_ADDRESS_CAPTURE_REPLAY_BIT;
rtForcedFlags.pNext = unwrapped.pNext;
unwrapped.pNext = &rtForcedFlags;
}
}
}
@@ -690,7 +700,7 @@ VkResult WrappedVulkan::vkAllocateMemory(VkDevice device, const VkMemoryAllocate
&serialisedInfo, VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_FLAGS_INFO);
// see above for this gross workaround we have to do
if(AccelerationStructures())
if(forceBDA)
{
if(memFlags)
{