lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-24 23:46:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add problems noticed during reading to debug messages list

Browse Source
This commit is contained in:
baldurk
2016-05-05 16:15:31 +02:00
parent 38cb1d796a
commit 5361654bbf
2 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/vk_core.cpp
+17 -6
View File
@@ -2383,7 +2383,7 @@ void WrappedVulkan::AddDrawcall(FetchDrawcall d, bool hasEvents)
VulkanDrawcallTreeNode node(draw);
if(m_LastCmdBufferID != ResourceId())
AddUsage(node);
AddUsage(node, m_BakedCmdBufferInfo[m_LastCmdBufferID].debugMessages);
node.children.insert(node.children.begin(), draw.children.elems, draw.children.elems+draw.children.count);
GetDrawcallStack().back()->children.push_back(node);
@@ -2392,7 +2392,7 @@ void WrappedVulkan::AddDrawcall(FetchDrawcall d, bool hasEvents)
RDCERR("Somehow lost drawcall stack!");
}
void WrappedVulkan::AddUsage(VulkanDrawcallTreeNode &drawNode)
void WrappedVulkan::AddUsage(VulkanDrawcallTreeNode &drawNode, vector<DebugMessage> &debugMessages)
{
FetchDrawcall &d = drawNode.draw;
@@ -2440,6 +2440,13 @@ void WrappedVulkan::AddUsage(VulkanDrawcallTreeNode &drawNode)
ResUsageType(sh.mapping->ConstantBlocks, eUsage_VS_Constants),
};
DebugMessage msg;
msg.eventID = e;
msg.category = eDbgCategory_Execution;
msg.messageID = 0;
msg.source = eDbgSource_IncorrectAPIUse;
msg.severity = eDbgSeverity_High;
for(size_t t=0; t < ARRAY_COUNT(types); t++)
{
for(int32_t i=0; i < types[t].bindmap.count; i++)
@@ -2454,7 +2461,8 @@ void WrappedVulkan::AddUsage(VulkanDrawcallTreeNode &drawNode)
if(bindset >= (int32_t)descSets.size())
{
RDCWARN("At draw %u, shader referenced a descriptor set %i that was not bound", drawNode.draw.eventID, bindset);
msg.description = StringFormat::Fmt("Shader referenced a descriptor set %i that was not bound", bindset);
debugMessages.push_back(msg);
continue;
}
@@ -2463,13 +2471,15 @@ void WrappedVulkan::AddUsage(VulkanDrawcallTreeNode &drawNode)
if(layout.bindings.empty())
{
RDCWARN("At draw %u, shader referenced a descriptor set %i that was not bound", drawNode.draw.eventID, bindset);
msg.description = StringFormat::Fmt("Shader referenced a descriptor set %i that was not bound", bindset);
debugMessages.push_back(msg);
continue;
}
if(bind >= (int32_t)layout.bindings.size())
{
RDCWARN("At draw %u, shader referenced a bind %i in descriptor set %i that does not exist. Mismatched descriptor set?", drawNode.draw.eventID, bind, bindset);
msg.description = StringFormat::Fmt("Shader referenced a bind %i in descriptor set %i that does not exist. Mismatched descriptor set?", bind, bindset);
debugMessages.push_back(msg);
continue;
}
@@ -2485,7 +2495,8 @@ void WrappedVulkan::AddUsage(VulkanDrawcallTreeNode &drawNode)
if(bind >= (int32_t)descset.currentBindings.size())
{
RDCWARN("At draw %u, shader referenced a bind %i in descriptor set %i that does not exist. Mismatched descriptor set?", drawNode.draw.eventID, bind, bindset);
msg.description = StringFormat::Fmt("Shader referenced a bind %i in descriptor set %i that does not exist. Mismatched descriptor set?", bind, bindset);
debugMessages.push_back(msg);
continue;
}
renderdoc/driver/vulkan/vk_core.h
+1 -1
View File
@@ -529,7 +529,7 @@ private:
void AddDrawcall(FetchDrawcall d, bool hasEvents);
void AddEvent(VulkanChunkType type, string description);
void AddUsage(VulkanDrawcallTreeNode &drawNode);
void AddUsage(VulkanDrawcallTreeNode &drawNode, vector<DebugMessage> &debugMessages);
// no copy semantics
WrappedVulkan(const WrappedVulkan &);