lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-05 01:20:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Emit error message instead of crashing for missing SSA variables

Browse Source 
Make GetLiveVariable() behave similarly to GetPhiVariable()
This commit is contained in:
Jake Turner
2025-02-21 15:45:20 +00:00
parent 8e733a7b01
commit 554e746cc8
1 changed files with 25 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/shaders/dxil/dxil_debug.cpp
+25 -7
View File
@@ -5666,19 +5666,37 @@ bool ThreadState::GetShaderVariableHelper(const DXIL::Value *dxilValue, DXIL::Op
bool ThreadState::IsVariableAssigned(const Id id) const
{
RDCASSERT(id < m_Assigned.size());
return m_Assigned[id];
if(id < m_Assigned.size())
{
return m_Assigned[id];
}
else
{
RDCERR("Variable Id %d is not in assigned list", id);
return false;
}
}
bool ThreadState::GetLiveVariable(const Id &id, Operation op, DXOp dxOpCode, ShaderVariable &var) const
{
RDCASSERT(id < m_Live.size());
RDCASSERT(m_Live[id]);
if(id < m_Live.size())
{
RDCASSERT(m_Live[id]);
}
else
{
RDCERR("Unknown Live Variable Id %d", id);
}
RDCASSERT(IsVariableAssigned(id));
auto it = m_Variables.find(id);
RDCASSERT(it != m_Variables.end());
var = it->second;
return GetVariableHelper(op, dxOpCode, var);
if(it != m_Variables.end())
{
var = it->second;
return GetVariableHelper(op, dxOpCode, var);
}
RDCERR("Unknown Variable %d", id);
return false;
}
bool ThreadState::GetPhiVariable(const Id &id, Operation op, DXOp dxOpCode, ShaderVariable &var) const