lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-29 13:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check final memory usage, not peak memory usage, in Repeat_Load test

Browse Source 
* We are really looking for persistent memory leaks here not fluctuations in
  memory use. There are too many false positives from memory usage increasing up
  high part-way through the iterations and then reducing down for the final
  iteration, which could be many lazy or deferred things running and completing
  over time.
This commit is contained in:
baldurk
2019-05-27 10:09:32 +01:00
parent 38d3145964
commit 57084fd911
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
util/test/tests/Repeat_Load.py
+6 -7
View File
@@ -7,10 +7,10 @@ class Repeat_Load(rdtest.TestCase):
slow_test = True
def repeat_load(self, path):
memory_peak = memory_baseline = 0
memory_usage = memory_baseline = 0
for i in range(20):
rdtest.log.print("Loading for iteration {}".format(i))
rdtest.log.print("Loading for iteration {}".format(i+1))
try:
controller = rdtest.open_capture(path)
@@ -25,7 +25,6 @@ class Repeat_Load(rdtest.TestCase):
# not be full
if i == 1:
memory_baseline = memory_usage
memory_peak = max(memory_peak, memory_usage)
controller.Shutdown()
@@ -35,12 +34,12 @@ class Repeat_Load(rdtest.TestCase):
pct_over = '{:.2f}%'.format((memory_usage / memory_baseline)*100)
rdtest.log.success("Succeeded iteration {}, memory usage was {} ({} of baseline)"
.format(i, memory_usage, pct_over))
.format(i+1, memory_usage, pct_over))
pct_over = '{:.2f}%'.format((memory_peak / memory_baseline)*100)
msg = 'peak memory usage was {}, {} compared to baseline {}'.format(memory_peak, pct_over, memory_baseline)
pct_over = '{:.2f}%'.format((memory_usage / memory_baseline)*100)
msg = 'final memory usage was {}, {} compared to baseline {}'.format(memory_usage, pct_over, memory_baseline)
if memory_baseline * 1.25 < memory_peak:
if memory_baseline * 1.25 < memory_usage:
raise rdtest.TestFailureException(msg)
else:
rdtest.log.success(msg)