lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-29 13:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Mapped memory offsets don't have to be aligned at all

Browse Source 
* The guarantee is that the base pointer (ie. returned pointer minus
  offset) is aligned to some value.
This commit is contained in:
baldurk
2015-12-02 20:27:03 +01:00
parent 3b9f4da65a
commit 5bb4b0dc13
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/wrappers/vk_resource_funcs.cpp
+4 -10
View File
@@ -368,11 +368,8 @@ bool WrappedVulkan::Serialise_vkUnmapMemory(
device = GetResourceManager()->GetLiveHandle<VkDevice>(devId);
mem = GetResourceManager()->GetLiveHandle<VkDeviceMemory>(id);
// VKTODOLOW figure out what alignments there are on mapping, so we only map the region
// we're going to modify. For now, offset/size is handled in the memcpy before and we
// map the whole region
void *mapPtr = NULL;
VkResult ret = ObjDisp(device)->MapMemory(Unwrap(device), Unwrap(mem), 0, 0, 0, &mapPtr);
VkResult ret = ObjDisp(device)->MapMemory(Unwrap(device), Unwrap(mem), memOffset, memSize, 0, &mapPtr);
if(ret != VK_SUCCESS)
{
@@ -380,7 +377,7 @@ bool WrappedVulkan::Serialise_vkUnmapMemory(
}
else
{
memcpy((byte *)mapPtr+memOffset, data, (size_t)memSize);
memcpy((byte *)mapPtr, data, (size_t)memSize);
ObjDisp(device)->UnmapMemory(Unwrap(device), Unwrap(mem));
}
@@ -493,11 +490,8 @@ bool WrappedVulkan::Serialise_vkFlushMappedMemoryRanges(
device = GetResourceManager()->GetLiveHandle<VkDevice>(devId);
VkDeviceMemory mem = GetResourceManager()->GetLiveHandle<VkDeviceMemory>(id);
// VKTODOLOW figure out what alignments there are on mapping, so we only map the region
// we're going to modify. For no, offset/size is handled in the memcpy before and we
// map the whole region
void *mapPtr = NULL;
VkResult ret = ObjDisp(device)->MapMemory(Unwrap(device), Unwrap(mem), 0, 0, 0, &mapPtr);
VkResult ret = ObjDisp(device)->MapMemory(Unwrap(device), Unwrap(mem), memOffset, memSize, 0, &mapPtr);
if(ret != VK_SUCCESS)
{
@@ -505,7 +499,7 @@ bool WrappedVulkan::Serialise_vkFlushMappedMemoryRanges(
}
else
{
memcpy((byte *)mapPtr+memOffset, data, (size_t)memSize);
memcpy((byte *)mapPtr, data, (size_t)memSize);
ObjDisp(device)->UnmapMemory(Unwrap(device), Unwrap(mem));
}