Ignore sets of empty name strings on resources

This commit is contained in:
baldurk
2020-09-01 11:09:03 +01:00
parent 865f9002da
commit 6b2f763bfa
5 changed files with 13 additions and 12 deletions
+2 -1
View File
@@ -2531,7 +2531,8 @@ bool WrappedID3D11Device::Serialise_SetResourceName(SerialiserType &ser,
{
ResourceDescription &descr = GetReplay()->GetResourceDesc(
GetResourceManager()->GetOriginalID(GetIDForResource(pResource)));
descr.SetCustomName(Name ? Name : "");
if(Name && Name[0])
descr.SetCustomName(Name);
AddResourceCurChunk(descr);
SetDebugName(pResource, Name);
+5 -5
View File
@@ -1157,7 +1157,6 @@ bool WrappedID3D12Device::Serialise_WrapSwapchainBuffer(SerialiserType &ser, IDX
WrappedID3D12Resource1 *wrapped = new WrappedID3D12Resource1(fakeBB, this);
fakeBB = wrapped;
m_ResourceNames[SwapbufferID] = "Swap Chain Buffer";
fakeBB->SetName(L"Swap Chain Buffer");
GetResourceManager()->AddLiveResource(SwapbufferID, fakeBB);
@@ -2607,13 +2606,14 @@ bool WrappedID3D12Device::Serialise_SetName(SerialiserType &ser, ID3D12DeviceChi
if(IsReplayingAndReading() && pResource)
{
ResourceId origId = GetResourceManager()->GetOriginalID(GetResID(pResource));
m_ResourceNames[origId] = Name ? Name : "";
ResourceDescription &descr = GetReplay()->GetResourceDesc(origId);
descr.SetCustomName(Name ? Name : "");
if(Name && Name[0])
{
descr.SetCustomName(Name);
pResource->SetName(StringFormat::UTF82Wide(Name).c_str());
}
AddResourceCurChunk(descr);
pResource->SetName(StringFormat::UTF82Wide(Name ? Name : "").c_str());
}
return true;
-3
View File
@@ -569,8 +569,6 @@ private:
std::set<ResourceId> m_Cubemaps;
std::map<ResourceId, rdcstr> m_ResourceNames;
// only valid on replay
std::map<ResourceId, WrappedID3D12Resource1 *> *m_ResourceList = NULL;
rdcarray<WrappedID3D12PipelineState *> *m_PipelineList = NULL;
@@ -658,7 +656,6 @@ public:
void AddResourceCurChunk(ResourceId id);
bool UsedDXIL() { return m_UsedDXIL; }
const rdcstr &GetResourceName(ResourceId id) { return m_ResourceNames[id]; }
rdcarray<D3D12_RESOURCE_STATES> &GetSubresourceStates(ResourceId id)
{
return m_ResourceStates[id];
@@ -141,7 +141,8 @@ bool WrappedOpenGL::Serialise_glObjectLabel(SerialiserType &ser, GLenum identifi
GetResourceManager()->SetName(origId, Label);
ResourceDescription &descr = GetReplay()->GetResourceDesc(origId);
descr.SetCustomName(Label);
if(!Label.empty())
descr.SetCustomName(Label);
AddResourceCurChunk(descr);
}
@@ -2028,7 +2028,8 @@ bool WrappedVulkan::Serialise_vkDebugMarkerSetObjectNameEXT(
ResourceDescription &descr = GetResourceDesc(Object);
AddResourceCurChunk(descr);
descr.SetCustomName(ObjectName);
if(ObjectName[0])
descr.SetCustomName(ObjectName);
}
return true;
@@ -2144,7 +2145,8 @@ bool WrappedVulkan::Serialise_vkSetDebugUtilsObjectNameEXT(
ResourceDescription &descr = GetResourceDesc(Object);
AddResourceCurChunk(descr);
descr.SetCustomName(ObjectName);
if(ObjectName[0])
descr.SetCustomName(ObjectName);
}
return true;