lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-25 16:06:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix overly-conservative buffer data fetch

Browse Source 
* This could be a big win in the case where a large object is instanced
  many times, we only fetch the data for the relevant instance output
  data, not ALL the output data.
This commit is contained in:
baldurk
2016-02-07 18:51:47 +01:00
parent 03488c2fa2
commit 6bd2a457b3
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/vk_replay.cpp
+15 -2
View File
@@ -1894,7 +1894,7 @@ void VulkanReplay::RenderMesh(uint32_t frameID, uint32_t eventID, const vector<M
vkr = vt->EndCommandBuffer(Unwrap(cmd));
RDCASSERT(vkr == VK_SUCCESS);
GetBufferData(cfg.position.buf, 0, 0, m_HighlightCache.data);
uint64_t maxIndex = cfg.position.numVerts;
if(cfg.position.idxByteWidth == 0 || stage == eMeshDataStage_GSOut)
{
@@ -1920,19 +1920,30 @@ void VulkanReplay::RenderMesh(uint32_t frameID, uint32_t eventID, const vector<M
if(bytesize == 1)
{
for(uint32_t i=0; i < numIndices; i++)
{
m_HighlightCache.indices[i] = uint32_t(idx8[i]);
maxIndex = RDCMAX(maxIndex, (uint64_t)m_HighlightCache.indices[i]);
}
}
else if(bytesize == 2)
{
for(uint32_t i=0; i < numIndices; i++)
{
m_HighlightCache.indices[i] = uint32_t(idx16[i]);
maxIndex = RDCMAX(maxIndex, (uint64_t)m_HighlightCache.indices[i]);
}
}
else if(bytesize == 4)
{
for(uint32_t i=0; i < numIndices; i++)
{
m_HighlightCache.indices[i] = idx32[i];
maxIndex = RDCMAX(maxIndex, (uint64_t)m_HighlightCache.indices[i]);
}
}
}
GetBufferData(cfg.position.buf, cfg.position.offset, (maxIndex+1)*cfg.position.stride, m_HighlightCache.data);
// get a new cmdbuffer and begin it
cmd = m_pDriver->GetNextCmd();
@@ -1951,7 +1962,9 @@ void VulkanReplay::RenderMesh(uint32_t frameID, uint32_t eventID, const vector<M
byte *data = &m_HighlightCache.data[0]; // buffer start
byte *dataEnd = data + m_HighlightCache.data.size();
data += cfg.position.offset; // to start of position data
// we already accounted for cfg.position.offset when fetching the cache
// above (since this is constant)
//data += cfg.position.offset; // to start of position data
///////////////////////////////////////////////////////////////
// vectors to be set from buffers, depending on topology