lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-08 02:50:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Speculative crash fix, protect against invalid indices in cbuffer tag

Browse Source
This commit is contained in:
baldurk
2021-06-15 16:24:25 +01:00
parent 9db41e0a5e
commit 71b6e2b321
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/PipelineState/D3D12PipelineStateViewer.cpp
+14 -4
View File
@@ -552,11 +552,21 @@ ResourceId D3D12PipelineStateViewer::GetResource(RDTreeWidgetItem *item)
if(cb.idx == ~0U)
{
// unused cbuffer, open regular buffer viewer
const D3D12Pipe::ConstantBuffer &buf =
m_Ctx.CurD3D12PipelineState()->rootElements[cb.rootElement].constantBuffers[cb.reg];
if(cb.rootElement < m_Ctx.CurD3D12PipelineState()->rootElements.size())
{
const D3D12Pipe::RootSignatureRange &range =
m_Ctx.CurD3D12PipelineState()->rootElements[cb.rootElement];
return buf.resourceId;
if(cb.reg < range.constantBuffers.size())
{
// unused cbuffer, open regular buffer viewer
const D3D12Pipe::ConstantBuffer &buf = range.constantBuffers[cb.reg];
return buf.resourceId;
}
}
return ResourceId();
}
return m_Ctx.CurPipelineState().GetConstantBuffer(stage->stage, cb.idx, cb.arrayIdx).resourceId;