lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-24 07:26:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix GC collection of python contexts

Browse Source
This commit is contained in:
baldurk
2026-08-13 17:46:38 +01:00
parent 9bb79a0594
commit 7567cc11c9
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Code/pyrenderdoc/PythonContext.cpp
+15 -2
View File
@@ -514,8 +514,7 @@ PythonContext::PythonContext(QObject *parent) : QObject(parent)
PythonContext::~PythonContext()
{
PyGILState_STATE gil = PyGILState_Ensure();
if(m_Completer)
Py_DecRef(m_Completer);
PyGILState_Release(gil);
// do a final tick to gather any remaining output
@@ -566,9 +565,23 @@ void PythonContext::Finish()
{
PyGILState_STATE gil = PyGILState_Ensure();
if(m_Completer)
{
Py_DecRef(m_Completer);
m_Completer = NULL;
}
// release our external handle to globals. It'll now only be ref'd from inside
Py_XDECREF(context_namespace);
// force a GC to detect the cycle left
PyObject *gc = PyImport_ImportModule("gc");
if(gc)
{
Py_XDECREF(PyObject_CallMethod(gc, "collect", NULL));
Py_XDECREF(gc);
}
PyGILState_Release(gil);
}