lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-06 10:00:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't use glMapBufferRange to read indices, as it may not allow MAP_READ

Browse Source
This commit is contained in:
baldurk
2018-10-17 11:41:28 +01:00
parent 04fb615e3d
commit 7c31f3f171
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/gl/wrappers/gl_draw_funcs.cpp
+6 -5
View File
@@ -817,13 +817,17 @@ WrappedOpenGL::ClientMemoryData *WrappedOpenGL::CopyClientMemoryArrays(GLint fir
if(indexType != eGL_NONE && first == -1)
{
bytebuf readbackIndices;
// First time we know we are using client-memory along with indices.
// Iterate over the indices to find the range of client memory to copy.
if(idxbuf != 0)
{
// If we were using a real index buffer, read it back to check its range.
mmIndices =
GL.glMapBufferRange(eGL_ELEMENT_ARRAY_BUFFER, (size_t)indices, idxlen, eGL_MAP_READ_BIT);
readbackIndices.resize(idxlen);
GL.glGetBufferSubData(eGL_ELEMENT_ARRAY_BUFFER, (GLintptr)indices, idxlen,
readbackIndices.data());
mmIndices = readbackIndices.data();
}
size_t min = ~0u, max = 0;
@@ -856,9 +860,6 @@ WrappedOpenGL::ClientMemoryData *WrappedOpenGL::CopyClientMemoryArrays(GLint fir
first = (GLint)min;
count = (GLint)(max - min + 1);
if(idxbuf != 0)
GL.glUnmapBuffer(eGL_ELEMENT_ARRAY_BUFFER);
}
// App initially used client memory, so copy it into the temporary buffer.