lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-09-26 15:46:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure memory without initial states on vulkan are cleared properly

Browse Source 
* The code was already handling the replay optimisation level properly, but
  without a dummy initial contents we were never even getting to the apply for
  memory objects created mid-frame and so without any initial contents.
This commit is contained in:
baldurk
2025-09-16 17:07:08 +01:00
parent 157941e31f
commit 7ef361fec5
1 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/vk_initstate.cpp
+19 -2
View File
@@ -1784,6 +1784,11 @@ void WrappedVulkan::Create_InitialState(ResourceId id, WrappedVkRes *live, bool)
GetResourceManager()->SetInitialContents(id, VkInitialContents(type, tag));
}
else if(type == eResDeviceMemory)
{
// need to ensure there are initial contents to apply though we don't create any memory
GetResourceManager()->SetInitialContents(id, VkInitialContents(type, MemoryAllocation()));
}
else if(type == eResDeviceMemory || type == eResBuffer || type == eResAccelerationStructureKHR)
{
// ignore, it was probably dirty but not referenced in the frame
@@ -2347,7 +2352,12 @@ void WrappedVulkan::Apply_InitialState(WrappedVkRes *live, VkInitialContents &in
VkBuffer srcBuf = initial.buf;
VkBuffer dstBuf = m_CreationInfo.m_Memory[id].wholeMemBuf;
VkDeviceSize dstBufSize = RDCMIN(initial.mem.size, m_CreationInfo.m_Memory[id].wholeMemBufSize);
VkDeviceSize dstBufSize = m_CreationInfo.m_Memory[id].wholeMemBufSize;
// may have no initial memory if this is a created initial contents which we only clear
if(initial.mem.size != 0)
dstBufSize = RDCMIN(initial.mem.size, dstBufSize);
if(dstBuf == VK_NULL_HANDLE)
{
RDCERR("Whole memory buffer not present for %s", ToStr(orig).c_str());
@@ -2376,7 +2386,14 @@ void WrappedVulkan::Apply_InitialState(WrappedVkRes *live, VkInitialContents &in
VkDeviceSize start = it->start();
VkDeviceSize finish = RDCMIN(it->finish(), dstBufSize);
VkDeviceSize size = finish - start;
switch(it->value())
InitReqType req = it->value();
// if we would copy, but we don't have a source buffer then there were no saved initial
// contents because this buffer was created mid-frame. Clear instead
if(req == eInitReq_Copy && srcBuf == VK_NULL_HANDLE)
req = eInitReq_Clear;
switch(req)
{
case eInitReq_Clear:
if(finish >= dstBufSize)