Change DXBC::BasicDemangle() to pass by reference instead of value

renderdoc/driver/shaders/dxbc/dxbc_common.h

@@ -414,6 +414,6 @@ public:
                          rdcarray<SourceVariableMapping> &locals) const = 0;
 };
 
-rdcstr BasicDemangle(rdcstr possiblyMangledName);
+rdcstr BasicDemangle(const rdcstr &possiblyMangledName);
 
 };

renderdoc/driver/shaders/dxbc/dxbc_container.cpp

@@ -42,7 +42,7 @@ RDOC_EXTERN_CONFIG(rdcarray<rdcstr>, DXBC_Debug_SearchDirPaths);
 
 namespace DXBC
 {
-rdcstr BasicDemangle(rdcstr possiblyMangledName)
+rdcstr BasicDemangle(const rdcstr &possiblyMangledName)
 {
   if(possiblyMangledName.size() > 2 && possiblyMangledName[0] == '\x1' &&
      possiblyMangledName[1] == '?')