lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-11 01:01:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing lock around forced references removal

Browse Source
This commit is contained in:
baldurk
2025-02-13 23:53:38 +00:00
parent a17d95b836
commit 8fa5a71c2c
1 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/wrappers/vk_misc_funcs.cpp
+17 -1
View File
@@ -156,6 +156,18 @@ static void MakeSubpassLoadRP(RPCreateInfo &info, const RPCreateInfo *origInfo,
}
}
template <typename type>
bool RemoveForcedRef()
{
return false;
}
template <>
bool RemoveForcedRef<VkAccelerationStructureKHR>()
{
return true;
}
// note, for threading reasons we ensure to release the wrappers before
// releasing the underlying object. Otherwise after releasing the vulkan object
// that same handle could be returned by create on another thread, and we
@@ -166,7 +178,11 @@ static void MakeSubpassLoadRP(RPCreateInfo &info, const RPCreateInfo *origInfo,
if(obj == VK_NULL_HANDLE) \
return; \
type unwrappedObj = Unwrap(obj); \
m_ForcedReferences.removeOne(GetRecord(obj)); \
if(RemoveForcedRef<type>()) \
{ \
SCOPED_LOCK(m_ForcedReferencesLock); \
m_ForcedReferences.removeOne(GetRecord(obj)); \
} \
if(IsReplayMode(m_State)) \
m_CreationInfo.erase(GetResID(obj)); \
GetResourceManager()->ReleaseWrappedResource(obj, true); \