lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-21 14:06:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Coverity: Ensure bitshifts are done at 64-bit precision

Browse Source 
* We use more than 32-bits in the cache key, so we need to be sure that
  any bitshifts are done at 64-bit, since 32-bit shifts are undefined.
This commit is contained in:
baldurk
2016-06-09 13:57:01 -07:00
parent a990f5adb7
commit 943ecdef58
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/vk_debug.cpp
+5 -5
View File
@@ -4948,7 +4948,7 @@ MeshDisplayPipelines VulkanDebugManager::CacheMeshDisplayPipelines(const MeshFor
bit++;
RDCASSERT((uint32_t)primary.topo < 64);
key |= ((uint32_t)primary.topo & 0x3f) << bit;
key |= uint64_t((uint32_t)primary.topo & 0x3f) << bit;
bit += 6;
ResourceFormat fmt;
@@ -4971,20 +4971,20 @@ MeshDisplayPipelines VulkanDebugManager::CacheMeshDisplayPipelines(const MeshFor
RDCCOMPILE_ASSERT(VK_FORMAT_RANGE_SIZE <= 255,
"Mesh pipeline cache key needs an extra bit for format");
key |= ((uint32_t)primaryFmt & 0xff) << bit;
key |= uint64_t((uint32_t)primaryFmt & 0xff) << bit;
bit += 8;
key |= ((uint32_t)secondaryFmt & 0xff) << bit;
key |= uint64_t((uint32_t)secondaryFmt & 0xff) << bit;
bit += 8;
RDCASSERT(primary.stride <= 0xffff);
key |= ((uint32_t)primary.stride & 0xffff) << bit;
key |= uint64_t((uint32_t)primary.stride & 0xffff) << bit;
bit += 16;
if(secondary.buf != ResourceId())
{
RDCASSERT(secondary.stride <= 0xffff);
key |= ((uint32_t)secondary.stride & 0xffff) << bit;
key |= uint64_t((uint32_t)secondary.stride & 0xffff) << bit;
}
bit += 16;