Fix potential race when destroying windows while command is in flight

2026-05-04 17:10:47 +00:00 · 2023-05-08 13:46:13 +01:00
parent 5b81eff759
commit 9a21a66f7c
1 changed files with 8 additions and 2 deletions
@@ -2752,5 +2752,11 @@ data.
 rdcstr ConfigFilePath(const rdcstr &filename);

 // simple helper for the common case of 'we just need to run this on the replay thread'
-#define INVOKE_MEMFN(function) \
-  m_Ctx.Replay().AsyncInvoke([this](IReplayController *r) { function(r); });
+#define INVOKE_MEMFN(function)                                    \
+  {                                                               \
+    QPointer<std::remove_reference<decltype(*this)>::type> meptr; \
+    m_Ctx.Replay().AsyncInvoke([meptr](IReplayController *r) {    \
+      if(meptr)                                                   \
+        meptr->function(r);                                       \
+    });                                                           \
+  }