lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-05 01:20:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Speculative fix for race during performance counter selection

Browse Source 
* If the window is closed while counter enumeration is happening and that takes
  long enough this might break, so keep a QPointer around.
This commit is contained in:
baldurk
2023-02-17 14:48:52 +00:00
parent f05c4efde8
commit 9c71e9db02
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/Dialogs/PerformanceCounterSelection.cpp
+9 -5
View File
@@ -253,17 +253,21 @@ PerformanceCounterSelection::PerformanceCounterSelection(ICaptureContext &ctx,
ui->counterTree->setMouseTracking(true);
ctx.Replay().AsyncInvoke([this, selectedCounters](IReplayController *controller) {
QPointer<PerformanceCounterSelection> ptr(this);
ctx.Replay().AsyncInvoke([this, ptr, selectedCounters](IReplayController *controller) {
QVector<CounterDescription> counterDescriptions;
for(const GPUCounter counter : controller->EnumerateCounters())
{
counterDescriptions.append(controller->DescribeCounter(counter));
}
GUIInvoke::call(this, [counterDescriptions, selectedCounters, this]() {
SetCounters(counterDescriptions);
SetSelectedCounters(selectedCounters);
});
if(ptr)
{
GUIInvoke::call(this, [counterDescriptions, selectedCounters, this]() {
SetCounters(counterDescriptions);
SetSelectedCounters(selectedCounters);
});
}
});
}