lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-04 17:10:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix some cases where buffer memory requirements were assumed to be tight

Browse Source 
* It's possible for a buffer to require more memory than its size (e.g. up to
  some alignment)
This commit is contained in:
baldurk
2022-02-08 17:46:49 +00:00
parent a8e7b64a31
commit b38f8b8378
3 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/vk_initstate.cpp
-7
View File
@@ -506,13 +506,6 @@ bool WrappedVulkan::Prepare_InitialState(WrappedVkRes *res)
if(readbackmem.mem == VK_NULL_HANDLE)
return false;
// dummy request to keep the validation layers happy - the buffers are identical so the
// requirements must be identical
{
VkMemoryRequirements mrq = {0};
ObjDisp(d)->GetBufferMemoryRequirements(Unwrap(d), Unwrap(dstBuf), &mrq);
}
CheckVkResult(vkr);
vkr = ObjDisp(d)->BindBufferMemory(Unwrap(d), Unwrap(dstBuf), Unwrap(readbackmem.mem),
readbackmem.offs);
renderdoc/driver/vulkan/vk_outputwindow.cpp
+1 -1
View File
@@ -693,7 +693,7 @@ void VulkanReplay::GetOutputWindowData(uint64_t id, bytebuf &retData)
vt->GetBufferMemoryRequirements(Unwrap(device), readbackBuf, &mrq);
VkMemoryAllocateInfo allocInfo = {
VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO, NULL, bufInfo.size,
VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO, NULL, mrq.size,
m_pDriver->GetReadbackMemoryIndex(mrq.memoryTypeBits),
};
renderdoc/driver/vulkan/vk_replay.cpp
+1 -1
View File
@@ -3861,7 +3861,7 @@ void VulkanReplay::GetTextureData(ResourceId tex, const Subresource &sub,
vt->GetBufferMemoryRequirements(Unwrap(dev), readbackBuf, &mrq);
VkMemoryAllocateInfo allocInfo = {
VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO, NULL, dataSize,
VK_STRUCTURE_TYPE_MEMORY_ALLOCATE_INFO, NULL, mrq.size,
m_pDriver->GetReadbackMemoryIndex(mrq.memoryTypeBits),
};