lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-04 17:10:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't try to make package debuggable if remote server has disconnected

Browse Source
This commit is contained in:
baldurk
2018-01-29 18:02:23 +00:00
parent 06267312a2
commit b3d5704809
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/Dialogs/CaptureDialog.cpp
+13 -2
View File
@@ -457,6 +457,18 @@ void CaptureDialog::androidWarn_mouseClick()
{
QString exe = ui->exePath->text();
const RemoteHost *remote = m_Ctx.Replay().CurrentRemote();
if(!remote)
{
RDDialog::critical(this, tr("Android server disconnected"),
tr("You've been disconnected from the android server.\n\n"
"Please reconnect before attempting to fix package problems."));
return;
}
rdcstr host = remote->hostname;
QString caption = tr("Application is not debuggable");
QString msg = tr(R"(In order to debug on Android, the package must be <b>debuggable</b>.
@@ -478,8 +490,7 @@ Would you like RenderDoc to try patching your package?
bool patchSucceeded = false;
// call into APK pull, patch, install routine, then continue
LambdaThread *patch = new LambdaThread([this, exe, &patchSucceeded, &progress]() {
rdcstr host = m_Ctx.Replay().CurrentRemote()->hostname;
LambdaThread *patch = new LambdaThread([this, host, exe, &patchSucceeded, &progress]() {
AndroidFlags result = RENDERDOC_MakeDebuggablePackage(host.c_str(), exe.toUtf8().data(),
[&progress](float p) { progress = p; });