lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-05 09:30:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only check miptail parameters for compatibility when mip tail is present

Browse Source
This commit is contained in:
baldurk
2021-04-15 22:13:41 +01:00
parent 2720ff354a
commit bbb3d409c8
1 changed files with 31 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/vk_initstate.cpp
+31 -27
View File
@@ -748,15 +748,6 @@ SparseBinding::SparseBinding(WrappedVulkan *vk, VkImage unwrappedImage,
const Sparse::MipTail &mipTail = table.getMipTail();
// can't apply if the mip tail is differently shaped/sized
if(mipTail.byteOffset != reqs[a].imageMipTailOffset)
{
RDCERR("Captured mip tail for %s begins at offset %llu, on replay it begins at %llu",
ToStr((VkImageAspectFlagBits)tables[a].aspectMask).c_str(), mipTail.byteOffset,
reqs[a].imageMipTailOffset);
invalid = true;
return;
}
if(mipTail.firstMip != RDCMIN(table.getMipCount(), reqs[a].imageMipTailFirstLod))
{
RDCERR("Captured mip tail for %s begins at mip %u, on replay it begins at %u",
@@ -766,30 +757,43 @@ SparseBinding::SparseBinding(WrappedVulkan *vk, VkImage unwrappedImage,
return;
}
if(reqs[a].formatProperties.flags & VK_SPARSE_IMAGE_FORMAT_SINGLE_MIPTAIL_BIT)
// if we have a miptail, check its parameters
if(mipTail.firstMip < table.getMipCount())
{
if(mipTail.totalPackedByteSize != reqs[a].imageMipTailSize)
if(mipTail.byteOffset != reqs[a].imageMipTailOffset)
{
RDCERR("Captured single mip tail for %s is %llu bytes, on replay it is %llu",
ToStr((VkImageAspectFlagBits)tables[a].aspectMask).c_str(),
mipTail.totalPackedByteSize, reqs[a].imageMipTailSize);
RDCERR("Captured mip tail for %s begins at offset %llu, on replay it begins at %llu",
ToStr((VkImageAspectFlagBits)tables[a].aspectMask).c_str(), mipTail.byteOffset,
reqs[a].imageMipTailOffset);
invalid = true;
return;
}
}
else
{
if(mipTail.totalPackedByteSize / table.getArraySize() != reqs[a].imageMipTailSize ||
mipTail.byteStride != reqs[a].imageMipTailStride)
if(reqs[a].formatProperties.flags & VK_SPARSE_IMAGE_FORMAT_SINGLE_MIPTAIL_BIT)
{
RDCERR(
"Captured mip tail per slice for %s is %llu bytes with stride %llu, "
"on replay it is %llu bytes with stride %llu",
ToStr((VkImageAspectFlagBits)tables[a].aspectMask).c_str(),
mipTail.totalPackedByteSize / table.getArraySize(), mipTail.byteStride,
reqs[a].imageMipTailSize, reqs[a].imageMipTailStride);
invalid = true;
return;
if(mipTail.totalPackedByteSize != reqs[a].imageMipTailSize)
{
RDCERR("Captured single mip tail for %s is %llu bytes, on replay it is %llu",
ToStr((VkImageAspectFlagBits)tables[a].aspectMask).c_str(),
mipTail.totalPackedByteSize, reqs[a].imageMipTailSize);
invalid = true;
return;
}
}
else
{
if(mipTail.totalPackedByteSize / table.getArraySize() != reqs[a].imageMipTailSize ||
mipTail.byteStride != reqs[a].imageMipTailStride)
{
RDCERR(
"Captured mip tail per slice for %s is %llu bytes with stride %llu, "
"on replay it is %llu bytes with stride %llu",
ToStr((VkImageAspectFlagBits)tables[a].aspectMask).c_str(),
mipTail.totalPackedByteSize / table.getArraySize(), mipTail.byteStride,
reqs[a].imageMipTailSize, reqs[a].imageMipTailStride);
invalid = true;
return;
}
}
}