lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-24 07:26:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not pass std::string arguments to format string calls

Browse Source 
This comes up as a warning in VS2017, and all instances of this should
be unsafe given that std::string in MSVC only starts with a pointer when
the string contents is longer than the internal buffer, and of course
the size is larger than that of a pointer so all following arguments
wouldn't work either.
This commit is contained in:
Arseny Kapoulkine
2016-12-12 10:53:59 +00:00
committed by Baldur Karlsson
parent c2897ecb60
commit c4227e9a61
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/d3d11/d3d11_analyse.cpp
+1 -1
View File
@@ -549,7 +549,7 @@ ShaderDebug::State D3D11DebugManager::CreateShaderDebugState(ShaderDebugTrace &t
// if(sig.systemValue == TYPE_OUTPUT_CONTROL_POINT) str = "oOutputControlPoint";
else
{
RDCERR("Unhandled output: %s (%d)", sig.semanticName, sig.systemValue);
RDCERR("Unhandled output: %s (%d)", sig.semanticName.c_str(), sig.systemValue);
continue;
}
renderdoc/driver/shaders/dxbc/dxbc_debug.cpp
+8 -8
View File
@@ -2595,7 +2595,7 @@ State State::GetNext(GlobalState &global, State quad[4]) const
eDbgCategory_Shaders, eDbgSeverity_Medium, eDbgSource_RuntimeWarning,
StringFormat::Fmt(
"Shader debugging %d: %s\nNo targets bound for sampleinfo on rasterizer",
s.nextInstruction - 1, op.str));
s.nextInstruction - 1, op.str.c_str()));
}
SAFE_RELEASE(rtv);
@@ -2631,7 +2631,7 @@ State State::GetNext(GlobalState &global, State quad[4]) const
device->AddDebugMessage(
eDbgCategory_Shaders, eDbgSeverity_Medium, eDbgSource_RuntimeWarning,
StringFormat::Fmt("Shader debugging %d: %s\nSRV is NULL being queried by sampleinfo",
s.nextInstruction - 1, op.str));
s.nextInstruction - 1, op.str.c_str()));
}
SAFE_RELEASE(srv);
@@ -2665,7 +2665,7 @@ State State::GetNext(GlobalState &global, State quad[4]) const
device->AddDebugMessage(
eDbgCategory_Shaders, eDbgSeverity_Medium, eDbgSource_RuntimeWarning,
StringFormat::Fmt("Shader debugging %d: %s\nSRV is NULL being queried by sampleinfo",
s.nextInstruction - 1, op.str));
s.nextInstruction - 1, op.str.c_str()));
}
// "If there is no resource bound to the specified slot, 0 is returned."
@@ -2700,7 +2700,7 @@ State State::GetNext(GlobalState &global, State quad[4]) const
eDbgCategory_Shaders, eDbgSeverity_Medium, eDbgSource_RuntimeWarning,
StringFormat::Fmt(
"Shader debugging %d: %s\nNon-multisampled texture being passed to sample_pos",
s.nextInstruction - 1, op.str));
s.nextInstruction - 1, op.str.c_str()));
sample_pattern = NULL;
}
@@ -2849,7 +2849,7 @@ State State::GetNext(GlobalState &global, State quad[4]) const
eDbgCategory_Shaders, eDbgSeverity_High, eDbgSource_RuntimeWarning,
StringFormat::Fmt(
"Shader debugging %d: %s\nUAV being queried by bufinfo is not a buffer",
s.nextInstruction - 1, op.str));
s.nextInstruction - 1, op.str.c_str()));
}
}
else
@@ -2859,7 +2859,7 @@ State State::GetNext(GlobalState &global, State quad[4]) const
device->AddDebugMessage(
eDbgCategory_Shaders, eDbgSeverity_Medium, eDbgSource_RuntimeWarning,
StringFormat::Fmt("Shader debugging %d: %s\nUAV being queried by bufinfo is NULL",
s.nextInstruction - 1, op.str));
s.nextInstruction - 1, op.str.c_str()));
}
SAFE_RELEASE(uav);
@@ -2903,7 +2903,7 @@ State State::GetNext(GlobalState &global, State quad[4]) const
eDbgCategory_Shaders, eDbgSeverity_High, eDbgSource_RuntimeWarning,
StringFormat::Fmt(
"Shader debugging %d: %s\nSRV being queried by bufinfo is not a buffer",
s.nextInstruction - 1, op.str));
s.nextInstruction - 1, op.str.c_str()));
}
}
else
@@ -2913,7 +2913,7 @@ State State::GetNext(GlobalState &global, State quad[4]) const
device->AddDebugMessage(
eDbgCategory_Shaders, eDbgSeverity_Medium, eDbgSource_RuntimeWarning,
StringFormat::Fmt("Shader debugging %d: %s\nSRV being queried by bufinfo is NULL",
s.nextInstruction - 1, op.str));
s.nextInstruction - 1, op.str.c_str()));
}
SAFE_RELEASE(srv);