lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-07-08 08:40:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hook WSAStartup/WSACleanup to workaround app bugs. Refs #362, #403

Browse Source 
* If the application incorrectly calls WSACleanup() before WSAStartup()
  then instead of just an error for invalid use, it will instead kill
  all of the sockets we created from our early WSAStartup().
* To fix this, we hook those functions and track the process wide ref-
  count, to prevent it from every going to 0 until we shut down our own.
* This was found on GTA 5 in particular but possibly some other
  application will do this too.
This commit is contained in:
baldurk
2016-10-25 12:03:28 +02:00
parent ea657cd408
commit cde22aace7
1 changed files with 41 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/os/win32/sys_win32_hooks.cpp
+41
View File
@@ -23,6 +23,7 @@
* THE SOFTWARE.
******************************************************************************/
#include <winsock2.h>
#include "api/replay/renderdoc_replay.h"
#include "core/core.h"
#include "hooks/hooks.h"
@@ -30,6 +31,9 @@
#define DLL_NAME "kernel32.dll"
typedef int(WSAAPI *PFN_WSASTARTUP)(__in WORD wVersionRequested, __out LPWSADATA lpWSAData);
typedef int(WSAAPI *PFN_WSACLEANUP)();
typedef BOOL(WINAPI *PFN_CREATE_PROCESS_A)(
__in_opt LPCSTR lpApplicationName, __inout_opt LPSTR lpCommandLine,
__in_opt LPSECURITY_ATTRIBUTES lpProcessAttributes,
@@ -63,6 +67,12 @@ public:
success &= CreateProcessA.Initialize("CreateProcessA", DLL_NAME, CreateProcessA_hook);
success &= CreateProcessW.Initialize("CreateProcessW", DLL_NAME, CreateProcessW_hook);
success &= WSAStartup.Initialize("WSAStartup", "ws2_32.dll", WSAStartup_hook);
success &= WSACleanup.Initialize("WSACleanup", "ws2_32.dll", WSACleanup_hook);
// we start with a refcount of 1 because we initialise WSA ourselves for our own sockets.
m_WSARefCount = 1;
if(!success)
return false;
@@ -80,10 +90,41 @@ private:
bool m_HasHooks;
bool m_EnabledHooks;
int m_WSARefCount;
// D3DPERF api
Hook<PFN_CREATE_PROCESS_A> CreateProcessA;
Hook<PFN_CREATE_PROCESS_W> CreateProcessW;
Hook<PFN_WSASTARTUP> WSAStartup;
Hook<PFN_WSACLEANUP> WSACleanup;
static int WSAAPI WSAStartup_hook(WORD wVersionRequested, LPWSADATA lpWSAData)
{
int ret = syshooks.WSAStartup()(wVersionRequested, lpWSAData);
// only increment the refcount if the function succeeded
if(ret == 0)
syshooks.m_WSARefCount++;
return ret;
}
static int WSAAPI WSACleanup_hook()
{
// don't let the application murder our sockets with a mismatched WSACleanup() call
if(syshooks.m_WSARefCount == 1)
{
RDCLOG("WSACleanup called with (to the application) no WSAStartup! Ignoring.");
SetLastError(WSANOTINITIALISED);
return SOCKET_ERROR;
}
// decrement refcount and call the real thing
syshooks.m_WSARefCount--;
return syshooks.WSACleanup()();
}
static BOOL WINAPI CreateProcessA_hook(
__in_opt LPCSTR lpApplicationName, __inout_opt LPSTR lpCommandLine,
__in_opt LPSECURITY_ATTRIBUTES lpProcessAttributes,