lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-12 13:00:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

GL Depth Overlay use non-stencil mask approach by default

Browse Source 
Only use stencil mask approach for depth exporting shaders.
The stencil mask approach does not show discarded pixels as passing.
This commit is contained in:
Jake Turner
2024-01-10 12:12:05 +00:00
parent efc30ca723
commit d0166c0984
1 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/gl/gl_overlay.cpp
+20 -4
View File
@@ -1011,9 +1011,24 @@ ResourceId GLReplay::RenderOverlay(ResourceId texid, FloatVector clearCol, Debug
GLenum copyQueryEnum = texQueryEnum;
GLuint depthCopy = 0, stencilCopy = 0;
bool useBlitFramebuffer = true;
bool useDepthStencilMask = (overlay == DebugOverlay::Depth) && (curDepth != 0);
if(useDepthStencilMask)
{
useDepthStencilMask = false;
PerStageReflections stages;
m_pDriver->FillReflectionArray(rs.Program, stages);
const ShaderReflection *reflection = stages.refls[(uint32_t)ShaderStage::Fragment];
if(reflection)
{
for(const SigParameter &output : reflection->outputSignature)
{
if(output.systemValue == ShaderBuiltin::DepthOutput)
useDepthStencilMask = true;
}
}
}
// create matching depth for existing FBO
if(curDepth != 0)
{
@@ -1051,8 +1066,8 @@ ResourceId GLReplay::RenderOverlay(ResourceId texid, FloatVector clearCol, Debug
else if(depth == 0 && stencil == 8)
fmt = eGL_STENCIL_INDEX8;
}
// For depth overlay : need a stencil buffer
if(overlay == DebugOverlay::Depth)
// Need a stencil buffer for the depth overlay stencil mask method
if(useDepthStencilMask)
{
GLenum oldFmt = fmt;
if((oldFmt == eGL_DEPTH_COMPONENT16) || (oldFmt == eGL_DEPTH_COMPONENT24) ||
@@ -1066,11 +1081,11 @@ ResourceId GLReplay::RenderOverlay(ResourceId texid, FloatVector clearCol, Debug
if(DebugData.overlayTexSlices > 1)
{
useDepthStencilMask = false;
fmt = oldFmt;
RDCWARN("Depth overlay using fallback method instead of stencil mask");
}
else
{
useBlitFramebuffer = false;
curStencil = curDepth;
}
}
@@ -1271,6 +1286,7 @@ ResourceId GLReplay::RenderOverlay(ResourceId texid, FloatVector clearCol, Debug
stencilCopy, sub.mip);
}
bool useBlitFramebuffer = !useDepthStencilMask;
if(useBlitFramebuffer)
{
// get latest depth/stencil from read FBO (existing FBO) into draw FBO (overlay FBO)