lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-06 01:50:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix a crash if vertex input is instanced, with instance rate of 0

Browse Source 
* In this case, every input takes the first index, need to avoid divide
  by 0 error.
This commit is contained in:
baldurk
2015-03-11 08:04:19 +00:00
parent c3e381a76a
commit e7307455f6
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdocui/Windows/BufferViewer.cs
+16 -6
View File
@@ -1404,9 +1404,14 @@ namespace renderdocui.Windows
Stream strm = state.m_Stream[bufferFormats[el].buffer];
BinaryReader read = state.m_Reader[bufferFormats[el].buffer];
uint offs = input.Strides[bufferFormats[el].buffer] *
(bufferFormats[el].perinstance ? (instance/(uint)bufferFormats[el].instancerate) : index)
+ bufferFormats[el].offset;
uint instIdx = 0;
// for instancing, need to handle instance rate being 0 (every instance takes index 0 in that case)
if (bufferFormats[el].perinstance)
instIdx = bufferFormats[el].instancerate > 0 ? (instance / (uint)bufferFormats[el].instancerate) : 0;
else
instIdx = index;
uint offs = input.Strides[bufferFormats[el].buffer] * instIdx + bufferFormats[el].offset;
if (!MeshView)
offs += ByteOffset;
@@ -1681,9 +1686,14 @@ namespace renderdocui.Windows
Stream strm = state.m_Stream[bufferFormats[el].buffer];
BinaryReader read = state.m_Reader[bufferFormats[el].buffer];
uint offs = input.Strides[bufferFormats[el].buffer] *
(bufferFormats[el].perinstance ? (instance / (uint)bufferFormats[el].instancerate) : dataIndex)
+ bufferFormats[el].offset;
uint instIdx = 0;
// for instancing, need to handle instance rate being 0 (every instance takes index 0 in that case)
if (bufferFormats[el].perinstance)
instIdx = bufferFormats[el].instancerate > 0 ? (instance / (uint)bufferFormats[el].instancerate) : 0;
else
instIdx = dataIndex;
uint offs = input.Strides[bufferFormats[el].buffer] * instIdx + bufferFormats[el].offset;
if (!MeshView)
offs += ByteOffset;