lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-25 16:06:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential race in memory free code on shutdown

Browse Source
This commit is contained in:
baldurk
2026-02-13 13:54:36 +00:00
parent 1f05fc8564
commit e8e20a7444
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/vk_memory.cpp
+13 -6
View File
@@ -558,12 +558,19 @@ void WrappedVulkan::FreeAllMemory(MemoryScope scope)
rdcarray<MemoryAllocation> allocs;
allocs.swap(allocList);
m_MemoryFreeThread = Threading::CreateThread([this, d, allocs]() {
for(const MemoryAllocation &alloc : allocs)
{
ObjDisp(d)->FreeMemory(Unwrap(d), Unwrap(alloc.mem), NULL);
GetResourceManager()->ReleaseWrappedResource(alloc.mem);
}
rdcarray<VkDeviceMemory> mems;
mems.reserve(allocs.size());
// clean up resource manager book-keeping as this is not thread safe and is fast anyway
for(const MemoryAllocation &alloc : allocs)
{
mems.push_back(Unwrap(alloc.mem));
GetResourceManager()->ReleaseWrappedResource(alloc.mem);
}
m_MemoryFreeThread = Threading::CreateThread([this, d, mems]() {
for(VkDeviceMemory mem : mems)
ObjDisp(d)->FreeMemory(Unwrap(d), mem, NULL);
});
}