lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-16 23:10:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add warnings and skip when shader needs desc sets/binds that are unbound

Browse Source 
* These should be converted into log warnings/errors soon.
This commit is contained in:
baldurk
2016-04-11 20:55:56 +02:00
parent 9536962156
commit edd61c4486
1 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/vk_core.cpp
+21 -3
View File
@@ -2130,12 +2130,26 @@ void WrappedVulkan::AddUsage(VulkanDrawcallTreeNode &drawNode)
int32_t bindset = types[t].bindmap[i].bindset;
int32_t bind = types[t].bindmap[i].bind;
RDCASSERT(bindset < (int32_t)descSets.size());
if(bindset >= (int32_t)descSets.size())
{
RDCWARN("At draw %u, shader referenced a descriptor set %i that was not bound", drawNode.draw.eventID, bindset);
continue;
}
DescriptorSetInfo &descset = m_DescriptorSetState[ descSets[bindset] ];
DescSetLayout &layout = c.m_DescSetLayout[ descset.layout ];
RDCASSERT(bind < (int32_t)layout.bindings.size());
if(layout.bindings.empty())
{
RDCWARN("At draw %u, shader referenced a descriptor set %i that was not bound", drawNode.draw.eventID, bindset);
continue;
}
if(bind >= (int32_t)layout.bindings.size())
{
RDCWARN("At draw %u, shader referenced a bind %i in descriptor set %i that does not exist. Mismatched descriptor set?", drawNode.draw.eventID, bind, bindset);
continue;
}
// handled as part of the framebuffer attachments
if(layout.bindings[bind].descriptorType == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT)
@@ -2147,7 +2161,11 @@ void WrappedVulkan::AddUsage(VulkanDrawcallTreeNode &drawNode)
ResourceUsage usage = ResourceUsage(types[t].usage + shad);
RDCASSERT(bind < (int32_t)descset.currentBindings.size());
if(bind >= (int32_t)descset.currentBindings.size())
{
RDCWARN("At draw %u, shader referenced a bind %i in descriptor set %i that does not exist. Mismatched descriptor set?", drawNode.draw.eventID, bind, bindset);
continue;
}
for(uint32_t a=0; a < layout.bindings[bind].descriptorCount; a++)
{