lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-25 16:06:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

mark VKTODOs to do with GPU/device portability as such

Browse Source 
* These won't get addressed before 1.0
This commit is contained in:
baldurk
2016-02-07 18:47:54 +01:00
parent e8ded0d785
commit f2d123a0e6
3 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/vk_common.h
+3
View File
@@ -24,6 +24,9 @@
#pragma once
// PORTABILITY - parts of the code that need to change/update to handle
// portability between different GPU setups/capabilities etc
// MULTIDEVICE - parts of the code that will need to be updated to support
// multiple devices or queues.
renderdoc/driver/vulkan/wrappers/vk_device_funcs.cpp
+3 -3
View File
@@ -48,7 +48,7 @@ void WrappedVulkan::Initialise(VkInitParams &params)
params.AppName = string("RenderDoc @ ") + params.AppName;
params.EngineName = string("RenderDoc @ ") + params.EngineName;
// VKTODOLOW verify that layers/extensions are available
// PORTABILITY verify that layers/extensions are available
// don't try and create our own layer on replay!
for(auto it = params.Layers.begin(); it != params.Layers.end(); ++it)
@@ -280,7 +280,7 @@ bool WrappedVulkan::Serialise_vkEnumeratePhysicalDevices(
vkr = ObjDisp(instance)->EnumeratePhysicalDevices(Unwrap(instance), &count, devices);
RDCASSERT(vkr == VK_SUCCESS);
// VKTODOLOW match up physical devices to those available on replay
// PORTABILITY match up physical devices to those available on replay
pd = devices[physIndex];
@@ -534,7 +534,7 @@ bool WrappedVulkan::Serialise_vkCreateDevice(
else
RDCWARN("tessellationSideEffects = false, Tess output mesh data will not be available");
// VKTODOLOW: check that extensions and layers supported in capture (from createInfo) are supported in replay
// PORTABILITY check that extensions and layers supported in capture (from createInfo) are supported in replay
VkResult ret = GetDeviceDispatchTable(NULL)->CreateDevice(Unwrap(physicalDevice), &createInfo, &device);
renderdoc/driver/vulkan/wrappers/vk_resource_funcs.cpp
+1 -1
View File
@@ -156,7 +156,7 @@ bool WrappedVulkan::Serialise_vkAllocMemory(
device = GetResourceManager()->GetLiveHandle<VkDevice>(devId);
// serialised memory type index is non-remapped, so we remap now.
// VKTODOLOW may need to re-write info to change memory type index to the
// PORTABILITY may need to re-write info to change memory type index to the
// appropriate index on replay
info.memoryTypeIndex = m_PhysicalDeviceData.memIdxMap[info.memoryTypeIndex];