lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-12 13:00:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Coverity: Initialise VkMemoryRequirements to 0 in case it's not written

Browse Source
This commit is contained in:
baldurk
2016-06-09 11:39:49 -07:00
parent 47e6b214b4
commit fdd53feae0
3 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/vk_core.cpp
+1 -1
View File
@@ -1108,7 +1108,7 @@ bool WrappedVulkan::EndFrameCapture(void *dev, void *wnd)
vt->CreateImage(Unwrap(device), &imInfo, NULL, &readbackIm);
RDCASSERTEQUAL(vkr, VK_SUCCESS);
VkMemoryRequirements mrq;
VkMemoryRequirements mrq = {0};
vt->GetImageMemoryRequirements(Unwrap(device), readbackIm, &mrq);
VkImageSubresource subr = {VK_IMAGE_ASPECT_COLOR_BIT, 0, 0};
renderdoc/driver/vulkan/vk_debug.cpp
+8 -8
View File
@@ -796,7 +796,7 @@ VulkanDebugManager::VulkanDebugManager(WrappedVulkan *driver, VkDevice dev)
vkr = m_pDriver->vkCreateImage(dev, &imInfo, NULL, &m_TextAtlas);
RDCASSERTEQUAL(vkr, VK_SUCCESS);
VkMemoryRequirements mrq;
VkMemoryRequirements mrq = {0};
m_pDriver->vkGetImageMemoryRequirements(dev, m_TextAtlas, &mrq);
VkImageSubresource subr = {VK_IMAGE_ASPECT_COLOR_BIT, 0, 0};
@@ -1752,7 +1752,7 @@ VulkanDebugManager::VulkanDebugManager(WrappedVulkan *driver, VkDevice dev)
vkr = m_pDriver->vkCreateImage(dev, &imInfo, NULL, &m_TexDisplayDummyImages[index]);
RDCASSERTEQUAL(vkr, VK_SUCCESS);
VkMemoryRequirements mrq;
VkMemoryRequirements mrq = {0};
m_pDriver->vkGetImageMemoryRequirements(dev, m_TexDisplayDummyImages[index], &mrq);
uint32_t memIndex = driver->GetGPULocalMemoryIndex(mrq.memoryTypeBits);
@@ -1891,7 +1891,7 @@ VulkanDebugManager::VulkanDebugManager(WrappedVulkan *driver, VkDevice dev)
vkr = m_pDriver->vkCreateImage(dev, &imInfo, NULL, &m_PickPixelImage);
RDCASSERTEQUAL(vkr, VK_SUCCESS);
VkMemoryRequirements mrq;
VkMemoryRequirements mrq = {0};
m_pDriver->vkGetImageMemoryRequirements(dev, m_PickPixelImage, &mrq);
VkImageSubresource subr = {VK_IMAGE_ASPECT_COLOR_BIT, 0, 0};
@@ -2361,7 +2361,7 @@ void VulkanDebugManager::CreateCustomShaderTex(uint32_t width, uint32_t height)
vkr = m_pDriver->vkCreateImage(m_Device, &imInfo, NULL, &m_CustomTexImg);
RDCASSERTEQUAL(vkr, VK_SUCCESS);
VkMemoryRequirements mrq;
VkMemoryRequirements mrq = {0};
m_pDriver->vkGetImageMemoryRequirements(m_Device, m_CustomTexImg, &mrq);
// if no memory is allocated, or it's not enough,
@@ -3672,7 +3672,7 @@ ResourceId VulkanDebugManager::RenderOverlay(ResourceId texid, TextureDisplayOve
vkr = m_pDriver->vkCreateImage(m_Device, &imInfo, NULL, &m_OverlayImage);
RDCASSERTEQUAL(vkr, VK_SUCCESS);
VkMemoryRequirements mrq;
VkMemoryRequirements mrq = {0};
m_pDriver->vkGetImageMemoryRequirements(m_Device, m_OverlayImage, &mrq);
// if no memory is allocated, or it's not enough,
@@ -6253,7 +6253,7 @@ void VulkanDebugManager::InitPostVSBuffers(uint32_t eventID)
vkr = m_pDriver->vkCreateBuffer(dev, &bufInfo, NULL, &uniqIdxBuf);
RDCASSERTEQUAL(vkr, VK_SUCCESS);
VkMemoryRequirements mrq;
VkMemoryRequirements mrq = {0};
m_pDriver->vkGetBufferMemoryRequirements(dev, uniqIdxBuf, &mrq);
VkMemoryAllocateInfo allocInfo = {
@@ -6371,7 +6371,7 @@ void VulkanDebugManager::InitPostVSBuffers(uint32_t eventID)
vkr = m_pDriver->vkCreateBuffer(dev, &bufInfo, NULL, &readbackBuffer);
RDCASSERTEQUAL(vkr, VK_SUCCESS);
VkMemoryRequirements mrq;
VkMemoryRequirements mrq = {0};
m_pDriver->vkGetBufferMemoryRequirements(dev, meshBuffer, &mrq);
VkMemoryAllocateInfo allocInfo = {
@@ -6484,7 +6484,7 @@ void VulkanDebugManager::InitPostVSBuffers(uint32_t eventID)
vkr = m_pDriver->vkCreateBuffer(dev, &bufInfo, NULL, &readbackBuffer);
RDCASSERTEQUAL(vkr, VK_SUCCESS);
VkMemoryRequirements mrq;
VkMemoryRequirements mrq = {0};
m_pDriver->vkGetBufferMemoryRequirements(dev, meshBuffer, &mrq);
VkMemoryAllocateInfo allocInfo = {
renderdoc/driver/vulkan/vk_initstate.cpp
+1 -1
View File
@@ -845,7 +845,7 @@ bool WrappedVulkan::Apply_SparseInitialState(WrappedVkImage *im,
// sparse image? how is that determined?
VkSparseMemoryBind unbind = {0, 0, VK_NULL_HANDLE, 0, 0};
VkMemoryRequirements mrq;
VkMemoryRequirements mrq = {0};
ObjDisp(q)->GetImageMemoryRequirements(Unwrap(GetDev()), im->real.As<VkImage>(), &mrq);
unbind.size = mrq.size;