Commit Graph

2382 Commits

Author SHA1 Message Date
baldurk b8fd1fce02 When finding in the event browser, respect the current filter
* This means we'll jump to the nearest _visible_ result, rather than just the
  next result whether or not it's visible. This also applies to EID searches,
  when doing a go-to on a particular EID we'll end up jumping to the next
  visible EID.
2021-08-10 13:53:25 +01:00
baldurk 93f8a59a8f Linux compile fixes 2021-08-02 16:27:48 +01:00
baldurk a3d5404393 Don't use the W from VS input (and VS out with geom/tess) positions
* This allows W to be filled with 1.0 which our mesh viewing shader expects to
  have to be able to multiply by the MVP matrix.
2021-08-02 10:22:40 +01:00
baldurk 7e080857aa Fix an infinite recursion crash when opening the event browser
* If a capture was opened it would recurse between initialising the event
  browser and the marker breadcrumbs.
2021-08-02 10:05:42 +01:00
baldurk 9655a029a9 Handle fake markers in timeline bar. Closes #2327 2021-07-29 12:51:47 +01:00
baldurk faebd8b3c7 Fix old breadcrumbs persisting into new captures 2021-07-28 11:37:14 +01:00
baldurk 97a83f4dc4 Fix a crash with action durations if there are fake markers added 2021-07-28 11:37:14 +01:00
baldurk 4bb3286d05 Reset action timings when eventbrowser model is reset 2021-07-28 11:37:14 +01:00
baldurk 63e5448275 Fix naming of resource usage on GL/Vulkan 2021-07-28 11:37:14 +01:00
baldurk d0acc2a349 Fix display of typed buffers in D3D pipeline state viewer 2021-07-28 11:37:13 +01:00
baldurk 34a65857b1 Use custom sort on shader messages for location/workgroup
* The default sorting is purely text based so 1,0,0 is followed by 10,0,0 not
  2,0,0. We customise the sort so it does the right thing per-column.
2021-07-23 12:01:41 +01:00
baldurk 58afe63fe6 Fix export of shader messages from compute dispatches. Closes #2324 2021-07-23 11:48:07 +01:00
baldurk 4c4b0c58ec Fix 0-based line numbers in shader viewer find results
* Scintilla lines are numbered from 0 but for user display we want to be
  1-based.
2021-07-22 11:57:12 +01:00
baldurk bef75ce7fa Add export options and multi-select to shader msg viewer. Closes #2321 2021-07-22 11:41:20 +01:00
baldurk f06171f733 When copy-pasting from a treeview, trim each line individually
* This helps with views that have icon-only columns at the start or end, which
  would generate unnecessary whitespace when copying multiple lines.
2021-07-22 11:08:28 +01:00
baldurk 124d0e71b6 Implement more flexible step/run options. Closes #2276 Closes #2312
* We split stepping for source debugging into step over/into/out depending on
  how it handles function calls. Step Into is the same behaviour as before - it
  steps to the next source line executed regardless of if it's inside a function
  call. Step Over is similar but will not enter function calls. We define that
  as the callstack growing (so staying the same or shrinking - returning from a
  function - is OK), and this is as accurate as the underlying debug
  information. Step Out will run until the callstack shrinks, i.e. returning
  from a function.
* This is a slight behaviour change of keyboard shortcuts - F10 was effectively
  doing step into and will now step over. F11 will step into which is the old
  behaviour.
* All these variants have backwards versions, and to remain consistent we keep
  the shift modifier as forwards/backwards. This differs from visal studio where
  step out is shift-F10.
* The seems like the best balance - using any other variant would likely confuse
  muscle memory of anyone used to visual studio (where these shortcuts are
  intended to mimick), if only because F10 would be step into whether or not F11
  is used for step over or some other key which would likely be even more
  confusing either way. Trying to twist to use Shift-F10 for step out would be
  inconsistent with the other backwards running operations and likely cause more
  confusion than it saves in matching VS's shortcuts exactly. Also an accidental
  Shift-F10 is not too destructive, the user can realise it didn't Step Out
  forwards, and press Ctrl-F10 or look up the button.
* The hope is that most likely people doing source debugging and familiar with
  these keys expect F10 to step over, so the previous behaviour was unexpected
  but easy to work around, and that changing the meaning of the key won't
  disrupt them. Or at least the disruption is less than other alternatives.
2021-07-21 13:39:26 +01:00
baldurk 5d78cc9334 Update toolwindowmanager to dcb8d74 2021-07-20 18:19:50 +01:00
baldurk 71bbc53759 Implement double clicking to go to find-all results. Closes #2277 2021-07-20 16:59:11 +01:00
baldurk a88bc9dd7d Disable autocompletion for find/replace text 2021-07-20 16:58:55 +01:00
baldurk 091cde69d4 Slightly tweak find-all highlight colour. Refs #2277 2021-07-20 15:52:55 +01:00
baldurk 8d5ef8109e When pre-populating find text, also try current word and select the text 2021-07-20 15:41:29 +01:00
baldurk e182a477b8 Close floating find windows when pressing escape 2021-07-20 15:41:03 +01:00
baldurk 46266a9dd6 Implement bindless feedback for DXBC shaders on D3D12 with patching 2021-07-15 16:41:23 +01:00
baldurk a8da2fed64 Respect palette foreground colour properly in rich text
* This is particularly relevant for custom-background colour items on dark theme
  where we may switch to dark text for contrast.
2021-07-15 16:41:23 +01:00
baldurk f5f1737c83 Fix a bug with URL handling that would add richtext twice 2021-07-15 16:41:23 +01:00
baldurk e4325a1cc1 Add debugPrintfEXT to glsl syntax highlighting 2021-07-14 15:33:12 +01:00
baldurk 3d3e7506aa Fix parameter generation for RGP event names 2021-07-10 21:30:34 +01:00
baldurk 7c7e9df847 Try to produce old action names for RGP
* This may not work forever but remains compatible for now.
2021-07-09 19:02:49 +01:00
baldurk 96533c71f4 Use different dialog title for different export formats. Closes #2311 2021-07-08 10:35:54 +01:00
baldurk ba84a52c30 Fix compilation on mac 2021-07-01 20:29:51 +01:00
baldurk a0ec249c75 Fix compilation with older Qt versions 2021-07-01 20:29:46 +01:00
baldurk cad267eb41 Fix broken <code> tags in event browser filter documentation 2021-07-01 19:27:34 +01:00
baldurk dd9079e8d0 When using Ctrl-F to open find toolbar, ensure tool button is checked 2021-07-01 19:27:34 +01:00
baldurk 1a87e6b084 Avoid selecting red as a highlight colour for filters 2021-07-01 15:15:05 +01:00
baldurk e9c176cd7d Strike-out and don't colourise ignored expressions 2021-07-01 15:15:05 +01:00
baldurk 41e4cc43ec Fix filter highlight colours for dark theme 2021-07-01 15:15:05 +01:00
baldurk d0accc409b Rename 'name' member of ActionDescription to 'customName'
* This is a deliberate break of compatibility since the field is now often
  empty, for non-markers. This means code will get a more explicit error when
  the name is being referenced, so it can be updated to fetch the name it needs
  as needed.
2021-07-01 15:15:05 +01:00
baldurk 7149302680 Rename 'draw' or 'drawcall' to action
* There's not a good accepted terminology for this kind of event, and for
  historical reasons 'drawcall' has been the accepted term, even though
  that can be quite confusing when a dispatch or a copy is a 'drawcall'.
* This is particularly highlighted by the event browser filters where
  $draw() includes draws and dispatches, but $dispatch() only includes
  dispatches, it's hard to intuitively understand why $draw() matches all
  of these calls.
* As a result we've defined the term 'action' to cover these types of
  events in the same way that we defined 'event' in the first place to
  mean a single atomic API call.
2021-07-01 15:15:05 +01:00
baldurk e7785bd99e Document the flags in $draw(flags & ...) and improve docs formatting 2021-07-01 15:15:04 +01:00
baldurk 9536c07164 Add option to batch import or export filters 2021-07-01 15:15:04 +01:00
baldurk fe81f57316 Remove recent filters button in favour of styling a fake combo box
* The filter icon was confusing since it had a 'refresh' badge instead of
  'save/load/recent' type badge, and making the latter readable in a few pixels
  is not feasible. Having the combo dropdown with saved filters is as intuitive
  and works in-line.
2021-07-01 15:15:04 +01:00
baldurk 7a02ec749b Rename 'Settings' to 'Settings & Help' in filter toolbar 2021-07-01 15:15:04 +01:00
baldurk ae978fdb4f Add some example filters if none are saved 2021-07-01 15:15:04 +01:00
baldurk ec618896a8 Don't allow filter strip to be hidden
* This help prevents possible confusion if someone hides the filter with some
  exclusions active and gets confused why things aren't showing up.
2021-07-01 15:15:04 +01:00
baldurk a92ffa0173 Squeeze a little horizontal space by making root breadcrumb just an icon 2021-07-01 15:15:04 +01:00
baldurk e669eaebfc Ditch $any() and $all() in favour of simple paren nesting
* This means that literals are no longer allowed to contains ()s to match e.g.
  Draw( to implicitly exclude DrawIndexed().
2021-07-01 15:15:04 +01:00
baldurk 5abfb7d5a2 Add a filter $parent() or $childOf() to match events under a marker 2021-07-01 15:15:04 +01:00
baldurk 065d7202b0 Fix a crash with $param() filtering on fake markers 2021-07-01 15:15:04 +01:00
baldurk 0c63ff08ae Fix interaction of mixed must/normal filters 2021-07-01 15:15:04 +01:00
baldurk dc16db6c2d Disable the $event() filter for now
* It's of very little value and causes more confusion than it's worth.
2021-07-01 15:15:04 +01:00