lee/wanderer
1
0
Fork 0
mirror of https://github.com/wanderer-industries/wanderer synced 2026-08-25 15:26:33 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix the bookmark custom mapping save behavior by moving the updateSetting side effect outside of the state setter function. This ensures the remote setting updates correctly when the input loses focus.

Browse Source 
- fix(settings): Move `updateSetting` call outside of the `setLocalMapping` callback in `BookmarkNameFormatSetting`
This commit is contained in:
Drew Bonasera
2026-05-29 03:56:20 -04:00
parent 4950f1d7e7
commit aeb479b67a
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
assets/js/hooks/Mapper/components/mapRootContent/components/MapSettings/components/BookmarkNameFormatSetting.tsx
+12 -12
View File
@@ -70,21 +70,21 @@ const CustomMappingInput = ({
const handleBlur = useCallback((e: React.FocusEvent<HTMLInputElement>) => {
const val = e.target.value;
setLocalMapping(prev => {
const newMapping = { ...prev };
if (val === defaultVal) {
delete newMapping[mappingKey];
} else {
newMapping[mappingKey] = val;
}
const newMapping = { ...localMapping };
if (val === defaultVal) {
delete newMapping[mappingKey];
} else {
newMapping[mappingKey] = val;
}
const savedVal = savedMapping[mappingKey] !== undefined ? savedMapping[mappingKey] : defaultVal;
if (val === savedVal) return newMapping;
setLocalMapping(newMapping);
const savedVal = savedMapping[mappingKey] !== undefined ? savedMapping[mappingKey] : defaultVal;
if (val !== savedVal) {
updateSetting(UserSettingsRemoteProps.bookmark_custom_mapping, newMapping);
return newMapping;
});
}, [mappingKey, defaultVal, savedMapping, setLocalMapping, updateSetting]);
}
}, [mappingKey, defaultVal, savedMapping, localMapping, setLocalMapping, updateSetting]);
return (
<div className="flex flex-col gap-1 w-[120px]">