chore: release version v1.2.3

CHANGELOG.md

@@ -2,6 +2,15 @@
 
 <!-- changelog -->
 
+## [v1.2.3](https://github.com/wanderer-industries/wanderer/compare/v1.2.2...v1.2.3) (2024-10-02)
+
+
+
+
+### Bug Fixes:
+
+* Map: Fix map loading after select a different map.
+
 ## [v1.2.2](https://github.com/wanderer-industries/wanderer/compare/v1.2.1...v1.2.2) (2024-10-02)
 
 

assets/js/hooks/Mapper/index.tsx

@@ -23,7 +23,7 @@ export default {
       onError: handleError,
     });
 
-    this.pushEvent('loaded');
+    this.pushEvent('ui_loaded');
   },
 
   handleEventWrapper(event: string, handler: (payload: any) => void) {

lib/wanderer_app/character/tracker_manager_impl.ex

@@ -68,13 +68,16 @@ defmodule WandererApp.Character.TrackerManager.Impl do
         state
 
       false ->
-        WandererApp.Character.update_character_state(character_id, %{opts: opts})
-        :telemetry.execute([:wanderer_app, :character, :tracker, :started], %{count: 1})
-
         Logger.debug(fn -> "Start character tracker: #{inspect(character_id)}" end)
 
-        tracked_characters = [character_id | state.characters] |> Enum.uniq()
+        Task.start_link(fn ->
+          WandererApp.Character.update_character_state(character_id, %{opts: opts})
+          :telemetry.execute([:wanderer_app, :character, :tracker, :started], %{count: 1})
 
+          :ok
+        end)
+
+        tracked_characters = [character_id | state.characters] |> Enum.uniq()
         WandererApp.Cache.insert("tracked_characters", tracked_characters)
 
         %{state | characters: tracked_characters}

lib/wanderer_app/map/map_manager.ex

@@ -10,8 +10,8 @@ defmodule WandererApp.Map.Manager do
   alias WandererApp.Map.Server
   alias WandererApp.Map.ServerSupervisor
 
-  @maps_start_per_second 100
-  @maps_start_interval 1500
+  @maps_start_per_second 5
+  @maps_start_interval 1000
   @maps_queue :maps_queue
   @garbage_collection_interval :timer.hours(1)
   @check_maps_queue_interval :timer.seconds(1)

lib/wanderer_app/map/map_server_impl.ex

@@ -177,37 +177,45 @@ defmodule WandererApp.Map.Server.Impl do
     do: {:ok, map_id |> WandererApp.Map.list_characters()}
 
   def add_character(%{map_id: map_id} = state, %{id: character_id} = character, track_character) do
-    with :ok <- map_id |> WandererApp.Map.add_character(character),
-         {:ok, _} <-
-           WandererApp.MapCharacterSettingsRepo.create(%{
-             character_id: character_id,
-             map_id: map_id,
-             tracked: track_character
-           }),
-         {:ok, character} <- WandererApp.Character.get_character(character_id) do
-      broadcast!(map_id, :character_added, character)
+    Task.start_link(fn ->
+      with :ok <- map_id |> WandererApp.Map.add_character(character),
+           {:ok, _} <-
+             WandererApp.MapCharacterSettingsRepo.create(%{
+               character_id: character_id,
+               map_id: map_id,
+               tracked: track_character
+             }),
+           {:ok, character} <- WandererApp.Character.get_character(character_id) do
+        broadcast!(map_id, :character_added, character)
 
-      :telemetry.execute([:wanderer_app, :map, :character, :added], %{count: 1})
+        :telemetry.execute([:wanderer_app, :map, :character, :added], %{count: 1})
 
-      state
-    else
-      {:error, _error} ->
-        state
-    end
+        :ok
+      else
+        {:error, _error} ->
+          :ok
+      end
+    end)
+
+    state
   end
 
   def remove_character(%{map_id: map_id} = state, character_id) do
-    with :ok <- WandererApp.Map.remove_character(map_id, character_id),
-         {:ok, character} <- WandererApp.Character.get_character(character_id) do
-      broadcast!(map_id, :character_removed, character)
+    Task.start_link(fn ->
+      with :ok <- WandererApp.Map.remove_character(map_id, character_id),
+           {:ok, character} <- WandererApp.Character.get_character(character_id) do
+        broadcast!(map_id, :character_removed, character)
 
-      :telemetry.execute([:wanderer_app, :map, :character, :removed], %{count: 1})
+        :telemetry.execute([:wanderer_app, :map, :character, :removed], %{count: 1})
 
-      state
-    else
-      {:error, _error} ->
-        state
-    end
+        :ok
+      else
+        {:error, _error} ->
+          :ok
+      end
+    end)
+
+    state
   end
 
   def untrack_characters(%{map_id: map_id} = state, characters_ids) do

lib/wanderer_app_web/live/maps/map_live.ex

@@ -45,7 +45,7 @@ defmodule WandererAppWeb.MapLive do
          deleted: false
        } = map} ->
 
-        Process.send_after(self(), {:init_map, map}, 100)
+        Process.send_after(self(), {:init_map, map}, 10)
 
         socket
         |> assign(
@@ -114,7 +114,7 @@ defmodule WandererAppWeb.MapLive do
           }
         } = socket
       ) do
-    Task.async(fn -> _on_map_started(map_id, current_user, user_permissions) end)
+    _on_map_started(map_id, current_user, user_permissions)
 
     {:noreply, socket}
   end
@@ -386,17 +386,17 @@ defmodule WandererAppWeb.MapLive do
               page_title: map_name,
               user_permissions: user_permissions,
               tracked_character_ids: tracked_character_ids
-            }}, 100)
+            }}, 10)
 
         only_tracked_characters and can_track? and not all_character_tracked? ->
-          Process.send_after(self(), :not_all_characters_tracked, 100)
+          Process.send_after(self(), :not_all_characters_tracked, 10)
 
         true ->
-          Process.send_after(self(), :no_permissions, 100)
+          Process.send_after(self(), :no_permissions, 10)
       end
     else
       _ ->
-        Process.send_after(self(), :no_access, 100)
+        Process.send_after(self(), :no_access, 10)
     end
 
     {:noreply, socket}
@@ -404,13 +404,6 @@ defmodule WandererAppWeb.MapLive do
 
   def handle_info({:map_init, %{map_id: map_id} = initial_data}, socket) do
     Phoenix.PubSub.subscribe(WandererApp.PubSub, map_id)
-    WandererApp.Map.Manager.start_map(map_id)
-
-    {:ok, map_started} = WandererApp.Cache.lookup("map_#{map_id}:started", false)
-
-    if map_started do
-      Process.send_after(self(), %{event: :map_started}, 100)
-    end
 
     {:noreply,
       socket
@@ -464,7 +457,7 @@ defmodule WandererAppWeb.MapLive do
         map_id: map_id,
         user_characters: user_character_eve_ids,
         initial_data: initial_data
-      }}, 100)
+      }}, 10)
 
     {:noreply, socket}
   end
@@ -567,7 +560,15 @@ defmodule WandererAppWeb.MapLive do
   def handle_info(_event, socket), do: {:noreply, socket}
 
   @impl true
-  def handle_event("loaded", _body, socket) do
+  def handle_event("ui_loaded", _body, %{assigns: %{map_id: map_id}} = socket) do
+    {:ok, map_started} = WandererApp.Cache.lookup("map_#{map_id}:started", false)
+
+    if map_started do
+      Process.send_after(self(), %{event: :map_started}, 10)
+    else
+      WandererApp.Map.Manager.start_map(map_id)
+    end
+
     {:noreply, socket}
   end
 
@@ -577,7 +578,8 @@ defmodule WandererAppWeb.MapLive do
   end
 
   @impl true
-  def handle_event("change_map", %{"map_slug" => map_slug} = _event, socket) do
+  def handle_event("change_map", %{"map_slug" => map_slug} = _event, %{assigns: %{map_id: map_id}} = socket) do
+    Phoenix.PubSub.unsubscribe(WandererApp.PubSub, map_id)
     {:noreply, push_navigate(socket, to: ~p"/#{map_slug}")}
   end
 
@@ -1564,16 +1566,23 @@ defmodule WandererAppWeb.MapLive do
           )
           |> Map.put(:reset, true)
 
-        {:map_started_data,
-         %{
-           map_id: map_id,
-           user_characters: user_character_eve_ids,
-           initial_data: initial_data,
-           events: events
-         }}
+        Process.send_after(self(), {:map_start, %{
+          map_id: map_id,
+          user_characters: user_character_eve_ids,
+          initial_data: initial_data,
+          events: events
+        }}, 10)
+        # {:map_started_data,
+        #  %{
+        #    map_id: map_id,
+        #    user_characters: user_character_eve_ids,
+        #    initial_data: initial_data,
+        #    events: events
+        #  }}
 
       _ ->
-        {:map_error, :no_access}
+        Process.send_after(self(), {:map_error, :no_access}, 10)
+
     end
   end
 
@@ -2079,13 +2088,14 @@ defmodule WandererAppWeb.MapLive do
     :ok = WandererApp.Character.TrackerManager.start_tracking(character_id)
   end
 
-  defp _push_map_event(socket, type, event_body),
-    do:
+  defp _push_map_event(socket, type, event_body)
+    do
       socket
       |> push_event("map_event", %{
         type: type,
         body: event_body |> WandererApp.Utils.JSONUtil.compress()
       })
+    end
 
   defp map_id(%{assigns: %{map_id: map_id}} = _socket), do: map_id
 end

lib/wanderer_app_web/live/maps/map_live.html.heex

@@ -2,9 +2,10 @@
   id="map-loader"
   data-loading={show_loader("map-loader")}
   data-loaded={hide_loader("map-loader")}
-  class="!z-100 absolute w-screen h-screen bg-transparent hidden"
+  class="!z-100 w-screen h-screen hidden relative"
 >
-  <div class="flex w-full h-full items-center justify-center">
+  <div class="hs-overlay-backdrop transition duration absolute inset-0 blur" />
+  <div class="flex !z-[150] w-full h-full items-center justify-center">
     <div class="Loader" data-text="Wanderer">
       <span class="Loader__Circle"></span>
       <span class="Loader__Circle"></span>
@@ -12,6 +13,8 @@
       <span class="Loader__Circle"></span>
     </div>
   </div>
+
+
 </div>
 
 <div class="w-full h-full" id="mapper" phx-hook="Mapper" phx-update="ignore"></div>

mix.exs

@@ -2,7 +2,7 @@ defmodule WandererApp.MixProject do
   use Mix.Project
 
   @source_url "https://github.com/wanderer-industries/wanderer"
-  @version "1.2.2"
+  @version "1.2.3"
 
   def project do
     [