Rework

app/src/main/java/io/xpipe/app/rdp/CustomRdpClient.java

@@ -54,7 +54,7 @@ public class CustomRdpClient implements ExternalApplicationType, ExternalRdpClie
     }
 
     @Override
-    public boolean supportsPasswordPassing() {
+    public boolean supportsPasswordPassing(RdpLaunchConfig config) {
         return false;
     }
 

app/src/main/java/io/xpipe/app/rdp/DevolutionsRdpClient.java

@@ -56,7 +56,7 @@ public class DevolutionsRdpClient implements ExternalApplicationType.WindowsType
     }
 
     @Override
-    public boolean supportsPasswordPassing() {
+    public boolean supportsPasswordPassing(RdpLaunchConfig config) {
         return false;
     }
 

app/src/main/java/io/xpipe/app/rdp/ExternalRdpClient.java

@@ -83,7 +83,7 @@ public interface ExternalRdpClient extends PrefsValue {
 
     void launch(RdpLaunchConfig configuration) throws Exception;
 
-    boolean supportsPasswordPassing();
+    boolean supportsPasswordPassing(RdpLaunchConfig config);
 
     String getWebsite();
 

app/src/main/java/io/xpipe/app/rdp/FreeRdpClient.java

@@ -66,7 +66,7 @@ public class FreeRdpClient implements ExternalRdpClient {
     }
 
     @Override
-    public boolean supportsPasswordPassing() {
+    public boolean supportsPasswordPassing(RdpLaunchConfig config) {
         return true;
     }
 

app/src/main/java/io/xpipe/app/rdp/MstscRdpClient.java

@@ -199,7 +199,7 @@ public class MstscRdpClient implements ExternalApplicationType.PathApplication,
     }
 
     @Override
-    public boolean supportsPasswordPassing() {
+    public boolean supportsPasswordPassing(RdpLaunchConfig config) {
         return LocalShell.getLocalPowershell().isPresent();
     }
 
@@ -232,7 +232,7 @@ public class MstscRdpClient implements ExternalApplicationType.PathApplication,
     private RdpConfig getAdaptedConfig(RdpLaunchConfig configuration) throws Exception {
         var input = configuration.getConfig();
         var pass = configuration.getPassword();
-        if (input.get("password 51").isPresent() || !supportsPasswordPassing() || pass == null) {
+        if (input.get("password 51").isPresent() || !supportsPasswordPassing(configuration) || pass == null) {
             return input.overlay(Map.of("smart sizing", new RdpConfig.TypedValue("i", smartSizing ? "1" : "0")));
         }
 

app/src/main/java/io/xpipe/app/rdp/RemminaRdpClient.java

@@ -21,10 +21,14 @@ public class RemminaRdpClient implements ExternalApplicationType.LinuxApplicatio
         return List.of("auto connect", "password 51", "prompt for credentials", "smart sizing");
     }
 
+    private boolean containsOnlyRecognizedOptions(RdpLaunchConfig configuration) {
+        var l = new HashSet<>(configuration.getConfig().getContent().keySet());
+        toStrip().forEach(l::remove);
+        return l.size() == 2 && l.contains("username") && l.contains("full address");
+    }
+
     @Override
     public void launch(RdpLaunchConfig configuration) throws Exception {
-        RdpConfig c = configuration.getConfig();
-
         // Remmina does not support RemoteApps
         if (configuration.isRemoteApp()) {
             var freerdp = new FreeRdpClient();
@@ -34,9 +38,7 @@ public class RemminaRdpClient implements ExternalApplicationType.LinuxApplicatio
             }
         }
 
-        var l = new HashSet<>(c.getContent().keySet());
-        toStrip().forEach(l::remove);
-        if (l.size() == 2 && l.contains("username") && l.contains("full address")) {
+        if (containsOnlyRecognizedOptions(configuration)) {
             var encrypted = RemminaHelper.encryptPassword(configuration.getPassword());
             if (encrypted.isPresent()) {
                 var file = RemminaHelper.writeRemminaRdpConfigFile(configuration, encrypted.get());
@@ -45,14 +47,15 @@ public class RemminaRdpClient implements ExternalApplicationType.LinuxApplicatio
             }
         }
 
+        RdpConfig c = configuration.getConfig();
         var file = writeRdpConfigFile(configuration.getTitle(), c);
         launch(CommandBuilder.of().add("-c").addFile(file.toString()));
         LocalFileTracker.deleteOnExit(file);
     }
 
     @Override
-    public boolean supportsPasswordPassing() {
-        return false;
+    public boolean supportsPasswordPassing(RdpLaunchConfig config) {
+        return config.isRemoteApp() || containsOnlyRecognizedOptions(config);
     }
 
     @Override

app/src/main/java/io/xpipe/app/rdp/RemoteDesktopAppRdpClient.java

@@ -34,7 +34,7 @@ public class RemoteDesktopAppRdpClient implements ExternalApplicationType.MacApp
     }
 
     @Override
-    public boolean supportsPasswordPassing() {
+    public boolean supportsPasswordPassing(RdpLaunchConfig config) {
         return false;
     }
 

app/src/main/java/io/xpipe/app/rdp/WindowsAppRdpClient.java

@@ -33,7 +33,7 @@ public class WindowsAppRdpClient implements ExternalApplicationType.MacApplicati
     }
 
     @Override
-    public boolean supportsPasswordPassing() {
+    public boolean supportsPasswordPassing(RdpLaunchConfig config) {
         return false;
     }