Fix Type tooltip and FailTime condition per PR feedback

Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com> Agent-Logs-Url: https://github.com/ashaduri/gsmartcontrol/sessions/b9ea2530-2c7d-4061-accb-eb7d7bb1dc16
Make Type bold only on pre-failure attribute failure
2026-09-27 14:25:34 +00:00 · 2026-03-22 17:09:02 +00:00 · 2026-03-06 19:02:55 +00:00 · 2026-03-06 14:52:28 +00:00 · 2026-03-06 14:50:23 +00:00
1 changed files with 5 additions and 2 deletions
@@ -1139,7 +1139,7 @@ void GscInfoWindow::fill_ui_ata_attributes(const StoragePropertyRepository& prop

 	model_columns.add(columns_->ata_attribute_table_columns.type);
 	num_tree_col = app_gtkmm_create_tree_view_column(columns_->ata_attribute_table_columns.type, *treeview,
-			_("Type"), _("Alarm condition is reached when normalized value becomes less than or equal to threshold. Type indicates whether it's a signal of drive's pre-failure time or just an old age."), false, true);
+			_("Type"), _("Indicates whether an alarm for this attribute signals drive failure (pre-failure) or normal wear from drive age (old age)."), false, true);

 	// Doesn't carry that much info. Advanced users can look at the flags.
 // 		model_columns.add(attribute_table_columns.updated);
@@ -2098,7 +2098,10 @@ void GscInfoWindow::cell_renderer_for_ata_attributes(Gtk::CellRenderer* cr,
 			crt->property_weight() = Pango::WEIGHT_BOLD;
 		}
 		if (column_index == columns_->ata_attribute_table_columns.type.index()) {
-			if (attribute.attr_type == AtaStorageAttribute::AttributeType::Prefail) {
+			// Bold only when attribute has failed AND it's pre-failure type
+			if ((attribute.when_failed == AtaStorageAttribute::FailTime::Past
+					|| attribute.when_failed == AtaStorageAttribute::FailTime::Now)
+					&& attribute.attr_type == AtaStorageAttribute::AttributeType::Prefail) {
 				crt->property_weight() = Pango::WEIGHT_BOLD;
 			} else {  // reset to default value if reloading
 				crt->property_weight().reset_value();
Author	SHA1	Message	Date
anthropic-code-agent[bot]andashaduri	37090a8556	Fix Type tooltip and FailTime condition per PR feedback Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com> Agent-Logs-Url: https://github.com/ashaduri/gsmartcontrol/sessions/b9ea2530-2c7d-4061-accb-eb7d7bb1dc16	2026-03-22 17:09:02 +00:00
anthropic-code-agent[bot]andashaduri	99d358396b	Make Type bold only on pre-failure attribute failure - Type column now shows bold text only when BOTH conditions are met: 1. Attribute has actually failed (when_failed != None) 2. Attribute type is pre-failure - This provides visual emphasis for genuine pre-failure warnings - Normal pre-failure attributes (not failed) remain normal weight Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>	2026-03-06 19:02:55 +00:00
anthropic-code-agent[bot]andashaduri	d1d64693db	Clarify Type attribute explanation and remove bold formatting - Updated tooltip to clearly explain Type indicates alarm meaning - Removed bold formatting for "pre-failure" to reduce visual alarm - Changed text to emphasize Type is about alarm interpretation, not current status Co-authored-by: ashaduri <2302268+ashaduri@users.noreply.github.com>	2026-03-06 14:52:28 +00:00
anthropic-code-agent[bot]	480e060682	Initial plan	2026-03-06 14:50:23 +00:00