Don't pass strings by copy unnecessarily

This commit is contained in:
baldurk
2017-02-07 15:14:55 +00:00
parent 7c422e3651
commit 24564a5439
2 changed files with 7 additions and 4 deletions
+5 -2
View File
@@ -288,13 +288,16 @@ void PersistantConfig::AddRecentFile(QList<QString> &recentList, const QString &
}
}
void PersistantConfig::SetConfigSetting(QString name, QString value)
void PersistantConfig::SetConfigSetting(const QString &name, const QString &value)
{
if(name.isEmpty())
return;
ConfigSettings[name] = value;
RENDERDOC_SetConfigSetting(name.toUtf8().data(), value.toUtf8().data());
}
QString PersistantConfig::GetConfigSetting(QString name)
QString PersistantConfig::GetConfigSetting(const QString &name)
{
if(ConfigSettings.contains(name))
return ConfigSettings[name];
+2 -2
View File
@@ -155,8 +155,8 @@ public:
static void AddRecentFile(QList<QString> &recentList, const QString &file, int maxItems);
void SetConfigSetting(QString name, QString value);
QString GetConfigSetting(QString name);
void SetConfigSetting(const QString &name, const QString &value);
QString GetConfigSetting(const QString &name);
private:
bool Deserialize(const QString &filename);