lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-29 18:06:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Crash fix - protect against reflection being NULL

Browse Source 
* This lets renderdoc limp along if the reflection failed to be created
  (usually because the shader failed to compile as a separable program)
This commit is contained in:
baldurk
2016-04-17 17:10:42 +02:00
parent a969f3f5af
commit 328412aa23
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/gl/gl_shader_refl.cpp
+7 -5
View File
@@ -1854,10 +1854,10 @@ void GetBindpointMapping(const GLHookSet &gl, GLuint curProg, int shadIdx, Shade
eGL_REFERENCED_BY_COMPUTE_SHADER,
};
int32_t numResources = refl ? refl->ReadOnlyResources.count : 0;
int32_t numReadOnlyResources = refl ? refl->ReadOnlyResources.count : 0;
create_array_uninit(mapping.ReadOnlyResources, numResources);
for(int32_t i=0; i < numResources; i++)
create_array_uninit(mapping.ReadOnlyResources, numReadOnlyResources);
for(int32_t i=0; i < numReadOnlyResources; i++)
{
if(refl->ReadOnlyResources.elems[i].IsTexture)
{
@@ -1906,8 +1906,10 @@ void GetBindpointMapping(const GLHookSet &gl, GLuint curProg, int shadIdx, Shade
}
}
create_array_uninit(mapping.ReadWriteResources, refl->ReadWriteResources.count);
for(int32_t i=0; i < refl->ReadWriteResources.count; i++)
int32_t numReadWriteResources = refl ? refl->ReadWriteResources.count : 0;
create_array_uninit(mapping.ReadWriteResources, numReadWriteResources);
for(int32_t i=0; i < numReadWriteResources; i++)
{
if(refl->ReadWriteResources.elems[i].IsTexture)
{