mirror of
https://github.com/baldurk/renderdoc.git
synced 2026-07-08 08:40:55 +00:00
Disable force-crash for errors/asserts/etc in profile
* On balance I think this does more harm than good. The idea was to make sure errors don't get ignored when running in profile, but really all it did was mean people trying to debug renderdoc without much familiarity got confused as to why things crashed suddenly.
This commit is contained in:
@@ -100,7 +100,7 @@ uint32_t CalcNumMips(int Width, int Height, int Depth);
|
||||
#define RDCDUMP() do { OSUtility::ForceCrash(); } while(0)
|
||||
|
||||
#if !defined(RELEASE) || defined(FORCE_DEBUGBREAK)
|
||||
#define RDCBREAK() do { if(OSUtility::DebuggerPresent()) OS_DEBUG_BREAK(); else RDCDUMP(); } while(0)
|
||||
#define RDCBREAK() do { if(OSUtility::DebuggerPresent()) OS_DEBUG_BREAK(); } while(0)
|
||||
#else
|
||||
#define RDCBREAK() do { } while(0)
|
||||
#endif
|
||||
|
||||
@@ -4911,8 +4911,7 @@ void ParseSPIRV(uint32_t *spirv, size_t spirvLength, SPVModule &module)
|
||||
case spv::OpGroupDecorate:
|
||||
case spv::OpGroupMemberDecorate:
|
||||
case spv::OpDecorationGroup:
|
||||
// TODO
|
||||
RDCBREAK();
|
||||
RDCUNIMPLEMENTED("SPIR-V Group decorations");
|
||||
break;
|
||||
default:
|
||||
break;
|
||||
|
||||
Reference in New Issue
Block a user