mirror of
https://github.com/baldurk/renderdoc.git
synced 2026-05-06 01:50:38 +00:00
Only set ShaderEditing analytic bit when saving, not first editing
* This means if someone just clicks to edit but doesn't actually edit, won't register as having used the feature.
This commit is contained in:
@@ -717,8 +717,6 @@ void PipelineStateViewer::EditShader(ShaderStage shaderType, ResourceId id,
|
||||
const ShaderReflection *shaderDetails,
|
||||
const QString &entryFunc, const rdcstrpairs &files)
|
||||
{
|
||||
ANALYTIC_SET(UIFeatures.ShaderEditing, true);
|
||||
|
||||
IShaderViewer *sv = m_Ctx.EditShader(
|
||||
false, entryFunc, files,
|
||||
// save callback
|
||||
@@ -726,6 +724,8 @@ void PipelineStateViewer::EditShader(ShaderStage shaderType, ResourceId id,
|
||||
const rdcstrpairs &updatedfiles) {
|
||||
QString compileSource = updatedfiles[0].second;
|
||||
|
||||
ANALYTIC_SET(UIFeatures.ShaderEditing, true);
|
||||
|
||||
// try and match up #includes against the files that we have. This isn't always
|
||||
// possible as fxc only seems to include the source for files if something in
|
||||
// that file was included in the compiled output. So you might end up with
|
||||
|
||||
Reference in New Issue
Block a user