lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-04 09:00:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash if application submits the same command buffer multiple times

Browse Source 
* Proper applications should not do this within a frame but it is legal and some
  may.
This commit is contained in:
baldurk
2026-03-09 12:36:13 +00:00
parent da56cab59d
commit c984ff829a
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/wrappers/vk_cmd_funcs.cpp
+11 -1
View File
@@ -1671,7 +1671,17 @@ bool WrappedVulkan::Serialise_vkBeginCommandBuffer(SerialiserType &ser, VkComman
// (even if it's baked to several command buffers in the frame)
// there's no issue with clashes here.
m_RerecordCmds[BakedCommandBuffer] = cmd;
m_RerecordCmds[CommandBuffer] = cmd;
// we don't mark CommandBuffer as a rerecord command. The reason for this is in case
// applications do bad things and re-record and submit the same command buffer multiple
// times in a capture. In that event we could create a problem - when selecting a
// vkBeginCommandBuffer in a second submission of the same command buffer (baked twice) the
// command buffer ID that will come back will be the non-baked command buffer ID. If that is
// considered a re-record command buffer then we could submit events to that command buffer
// without having begun it.
//
// This only happens with an application that records and submits the same command buffer multiple
// times. If an application does the proper thing and records multiple command buffers then
// they will have a unique base command buffer ID and there is no risk of false-aliasing.
InsertCommandQueueFamily(BakedCommandBuffer, FindCommandQueueFamily(CommandBuffer));
m_RerecordCmdList.push_back({AllocateInfo.commandPool, cmd});