lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-23 15:06:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Try to handle no shared memory types between external & normal resources

Browse Source 
* This cannot be replayed, as the memory type selected will be invalid on replay
  for the buffer. However this lets us at least capture and if the buffer is
  destroyed or not used in the capture, the capture would succeed, so it's at
  least no worse.
This commit is contained in:
baldurk
2020-02-03 21:10:26 +00:00
parent bb43ba45e3
commit edbedd4484
1 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/vulkan/wrappers/vk_resource_funcs.cpp
+21 -2
View File
@@ -1318,7 +1318,16 @@ VkResult WrappedVulkan::vkCreateBuffer(VkDevice device, const VkBufferCreateInfo
record->resInfo->memreqs.size = RDCMAX(record->resInfo->memreqs.size, mrq.size);
record->resInfo->memreqs.alignment =
RDCMAX(record->resInfo->memreqs.size, mrq.alignment);
record->resInfo->memreqs.memoryTypeBits &= mrq.memoryTypeBits;
if((resInfo.memreqs.memoryTypeBits & mrq.memoryTypeBits) == 0)
{
RDCWARN(
"External buffer shares no memory types with non-external buffer. This buffer "
"will not be replayable.");
}
else
{
record->resInfo->memreqs.memoryTypeBits &= mrq.memoryTypeBits;
}
}
}
else
@@ -1782,7 +1791,17 @@ VkResult WrappedVulkan::vkCreateImage(VkDevice device, const VkImageCreateInfo *
resInfo.memreqs.size = RDCMAX(resInfo.memreqs.size, mrq.size);
resInfo.memreqs.alignment = RDCMAX(resInfo.memreqs.size, mrq.alignment);
resInfo.memreqs.memoryTypeBits &= mrq.memoryTypeBits;
if((resInfo.memreqs.memoryTypeBits & mrq.memoryTypeBits) == 0)
{
RDCWARN(
"External image shares no memory types with non-external image. This image "
"will not be replayable.");
}
else
{
resInfo.memreqs.memoryTypeBits &= mrq.memoryTypeBits;
}
}
}
else