Commit Graph
15545 Commits
Author SHA1 Message Date
baldurk e38e2d4177 Fix VK_Descriptor_Index test declaring too large array
* This was variably sized so in practice we didn't use it, but the spec still
  requires us to respect the max sizes that could be used for the upper bound
  and this lead to the wrong texture being sampled on NV.
2025-01-25 15:59:31 +00:00
baldurk 590f51151b Mark mesh shaders using task payloads as unsupported
* The mesh debugger implementation does not fetch the payload.
2025-01-24 16:38:36 +00:00
baldurk b8def8854e Fix typo accidentally introduced 2025-01-21 10:27:20 +00:00
baldurk fa2085860d Always prioritise loading a new d3dcompiler over re-using an old one
* Previously when replaying we'd always use our d3dcompiler_47.dll that we ship,
  but during capture we would always prioritise re-using an existing d3dcompiler
  that the process already had.
* Since it should be safe to have multiple (differently named) d3dcompiler's in
  the same process and we want to avoid using an old out of date d3dcompiler if
  possible, we prioritise loading a new d3dcompiler_47.dll over re-using an
  existing in-process d3dcompiler_43.dll
2025-01-17 15:43:51 +00:00
baldurk a3a5f07a7e Workaround compile error on old fxc's using .sample on 2DMS texture 2025-01-17 15:41:54 +00:00
baldurk 341ed79ed1 Print the reason for unoptimising shaders 2025-01-17 15:26:49 +00:00
baldurk 7cf63c71bc Add more robust error-checking for debug resources 2025-01-17 15:24:01 +00:00
baldurk 07bec58317 Don't create empty D3D12SDKLayers.dll file if not available 2025-01-17 15:21:44 +00:00
baldurk c97ac7907c Fix addressing calculation in sparse table mip tails with D3D12 wrapping 2025-01-17 13:37:16 +00:00
baldurk e1ff74fca6 Update valgrind suppressions 2025-01-17 11:39:52 +00:00
baldurk 7840000d24 Ensure descriptors are cleanly serialised and initialised for all types 2025-01-16 19:43:20 +00:00
baldurk e8abd693c6 Fix uninitialised struct being accessed in next chain unwrap helper 2025-01-16 19:43:03 +00:00
baldurk 9cfb2acdfa Strip any skipped resources (with no initial content data) on vulkan 2025-01-16 14:00:24 +00:00
baldurk 0f515d591a Don't assert on an empty next list of VkBindSparseInfo 2025-01-16 12:30:28 +00:00
baldurk 62a89fcf22 Quote newline entries for matrix CSV exports. Closes #3520 2025-01-16 12:04:15 +00:00
baldurk 4f91478f43 Switch installer custom action from jscript to vbscript
* MS has deleted vbscript because breaking things is fun, so we use jscript
  instead to do the weird replace of '#' so that numbers read from the registry
  can be compared to numbers
2025-01-14 17:54:54 +00:00
baldurk 6feafaf74e Workaround AMD driver bug
* This may be present on other drivers - the vulkan spec allows a NULL pointer
  (or really garbage)
2025-01-14 15:47:39 +00:00
baldurk 2dee289ff5 Fix calculation of OOB bounds on vulkan 2025-01-14 15:47:39 +00:00
baldurk 22e9ef1972 Ignore initial states for images that are still in UNDEFINED
* By definition they can't have meaningful contents.
2025-01-14 15:47:39 +00:00
baldurk 049ad9787d Don't assert on empty geometry list in BLAS if there should be no geoms 2025-01-14 15:16:07 +00:00
baldurk c8223f5869 Fix D3D12 descriptor indexing test for named descriptors 2025-01-14 12:18:31 +00:00
baldurk e692c30a05 Handle 16-bit types not being supported in demos project 2025-01-14 12:07:24 +00:00
baldurk 3c5ce8a84a Remove unused API function
* Headless windows are used as immutable in tests so allowing resizing is
  unnecessary complication
2025-01-13 11:09:10 +00:00
baldurk f3f0617b37 Do extremely stupid version checking to workaround dxc nonsense in tests
* On a new enough dxc we can pass a flag to tell it to ignore dxil.dll
* This allows the tests to run on the test machine with an old windows SDK
  (where the demos project copies the dxcompiler.dll + dxil.dll from) but still
  pull in a new dxcompiler.dll without having it break on an old dxil.dll
2025-01-13 11:02:22 +00:00
baldurk cd84566b1c Fix case where PreprocessLineDirectives could eat preamble before #line
* This would happen if a #line referenced the file it was already in - we would
  only start outputting lines starting from the first one. Normally in this case
  there's a #line before any text, but that's not guaranteed.
2025-01-10 15:51:26 +00:00
baldurk 2e3a54b9d0 Fix 64-bit type casts on linux 2025-01-10 14:21:26 +00:00
baldurk b46b8d96cf Prefer using custom D3D12/ local dxcompiler.dll in demos project 2025-01-10 11:29:28 +00:00
baldurk f6c016245e Fix indexing and dimension calculation for non-square matrices in DXIL 2025-01-10 11:20:32 +00:00
baldurk 7f294a7e68 Handle anonymous structs in DXIL 2025-01-10 11:20:18 +00:00
baldurk d526a1a076 Don't re-cache same types if AddDebugType is called again 2025-01-10 11:20:00 +00:00
baldurk d4ecc62684 Update GPUVA tracker API to only take address & ID for removal
* Size is not always set on removal and we were accidentally relying on it in
  the implementation.
2025-01-09 17:01:26 +00:00
baldurk 9582c1b624 Update GPUVA tracker to keep a list of overlaps
* This allows us to better return a valid mapped resource for an address even in
  the case of overlaps/aliasing which might otherwise 'hide' a larger buffer.
2025-01-09 17:01:26 +00:00
baldurk 14f238247b Add unit tests to GPUVA tracker and keep implementation private 2025-01-09 17:01:26 +00:00
baldurk 91e69bb0dd Improve assert on invalid nested chunk serialisation 2025-01-09 17:01:26 +00:00
Jake Turner 6b1b2fb7da Document DXIL Debugger memory allocation and pointer implementation
Renamed some containers to distinguish between real memory allocations and pointers to within an existing memory allocation

Replace some asserts with if's as part of defensive coding
2025-01-08 15:58:57 +00:00
Jake Turner 4b35fbcc96 Rationalise DXIL debugger instruction indexes
Use m_ActiveGlobalInstructionIdx instead of m_GlobalInstructionIdx
Removed m_GlobalInstructionIdx
2025-01-08 12:17:43 +00:00
Jake Turner a98d0a403f Improve DXIL callstack generation
Resolve debug scopes in a separate pass before callstacks
Walk callstacks using DILocation (DebugLocation) data (dwarf scopes and inlinedAt data)

For each DILocation
Walk scope upwards to fill in the callstack (always a dwarf scope)
Make new DILocation from inlinedAt and walk that DILocation
2025-01-08 10:29:10 +00:00
Jake Turner 1c7deb7df7 Extend handling in GetFunctionScopeName()
Now supports passing in:
DISubprogram
DILexicalBlock

In addition to existing support for:
DILocalVariable
DIGlobalVariable
2025-01-08 10:29:10 +00:00
Jake Turner 1c8766bd85 Expand out DXIL Debugger RDCASSERT's which were using ^ 2025-01-08 10:29:10 +00:00
Jake Turner 10500d0327 Use the baseEventID for checking if a glMultiDraw* is valid
Prevents driver crash is invalid data is passed to glMultiDraw* i.e. no vertex buffers.
2025-01-08 10:29:10 +00:00
baldurk 898e4e0028 Fix missing queue use in FlushLists call 2025-01-08 10:25:50 +00:00
Elliot SabaandBaldur Karlsson e6b4de8138 Android: Automaticaly add MANAGE_EXTERNAL_STORAGE permission to apps
This prevents the user from needing to click through a permission
granting screen on their device before the agent is able to run on the
device, but only does so if the API level is >= 30 (where this
permission has effect at all [0]) and if a particular property is set on
the device (`debug.renderdoc.autograntpermissions`) so as to avoid
potential pitfalls on unusual Android devices.

[0] https://developer.android.com/reference/android/Manifest.permission#MANAGE_EXTERNAL_STORAGE
2025-01-07 20:28:26 +00:00
baldurk 64c77e917e Be more consistent and conservative with GPU syncing on D3D12
* In some cases we were only syncing one queue when we needed to flush and sync
  the whole GPU. Rename functions to be more clear about what is being synced,
  and only sync one queue/our internal queue when we know that's the only work
  we need to wait on.
2025-01-07 16:54:52 +00:00
baldurk 74a6e28f5a Improve ability to redeclare buffer formats from struct definitions 2025-01-07 16:11:32 +00:00
baldurk 7edcbfbdbc Fix bitfields not being resolved before structure uses 2025-01-07 15:10:44 +00:00
baldurk 79be74a8ec Only modify bitfield properties if bitfields are active 2025-01-07 14:43:19 +00:00
baldurk 980b6a8bf0 Add test of SM6.7 bitfield reflection 2025-01-07 13:43:45 +00:00
baldurk 2d86fe6b12 Ensure log output is clean when listing available demos 2025-01-07 13:43:45 +00:00
baldurk 4d4fbdcaa3 Demos project loads D3D12.dll relative to exe not CWD 2025-01-07 13:43:45 +00:00
baldurk f04e574cda Recalculate offsets for structured buffers on DXIL
* The offsets provided in the reflection data are garbage :(
2025-01-07 13:19:28 +00:00