mirror of
https://github.com/baldurk/renderdoc.git
synced 2026-10-19 10:31:07 +00:00
Remove a couple of TODOs from GL driver
* GL_MIN_MAP_BUFFER_ALIGNMENT is now satisfied (up to 64), and from reading the spec, yes the mip dimensions have to be defined as standard, you can't define just some crazy custom mip chain sizes as that's invalid.
This commit is contained in:
1 parent
760e18c242
commit
b47fedf08c
2 files changed
-3
No files matched your search
@@ -431,7 +431,6 @@ void GLReplay::CacheTexture(ResourceId id)
|
||||
if(levelQueryType == eGL_TEXTURE_CUBE_MAP)
|
||||
levelQueryType = eGL_TEXTURE_CUBE_MAP_POSITIVE_X;
|
||||
|
||||
// TODO if I call this for levels 1, 2, .. etc. Can I get sizes that aren't mip dimensions?
|
||||
GLint width = 1, height = 1, depth = 1, samples=1;
|
||||
gl.glGetTextureLevelParameterivEXT(res.resource.name, levelQueryType, 0, eGL_TEXTURE_WIDTH, &width);
|
||||
gl.glGetTextureLevelParameterivEXT(res.resource.name, levelQueryType, 0, eGL_TEXTURE_HEIGHT, &height);
|
||||
|
||||
@@ -1280,8 +1280,6 @@ void *WrappedOpenGL::glMapNamedBufferEXT(GLuint buffer, GLenum access)
|
||||
return record->Map.ptr;
|
||||
}
|
||||
|
||||
// TODO align return pointer to GL_MIN_MAP_BUFFER_ALIGNMENT (min 64)
|
||||
|
||||
if(access == eGL_READ_ONLY)
|
||||
{
|
||||
record->Map.status = GLResourceRecord::Mapped_Read_Real;
|
||||
|
||||
Reference in new issue
Block a user