Commit Graph

15891 Commits

Author SHA1 Message Date
Jake Turner 2fbf85fad1 Divide up tests between Workgroup_Zoo and Subgroup_Zoo
Subgroup_Zoo : unit tests, non-trivial convergence tests moved to Workgroup_Zoo
Workgroup_Zoo : convergence tests, small number of unit tests (not full coverage)

Added checks for workgroup convergence in Workgroup_Zoo tests
* Vulkan uses barrier()
* D3D12 uses AllMemoryBarrierWithGroupSync()
* dispatches workgroup of 2x1x1
* test debug results for workgroup 1,0,0
2025-05-07 11:05:55 +01:00
Jake Turner 79e80c8337 Added assert for Op::ControlBarrier that the workgroup is converged
New helper method ThreadState::WorkgroupIsDiverged()
2025-05-07 11:03:20 +01:00
baldurk c945293b3e Add sanity checking strict mode to build scripts 2025-05-06 12:42:23 +01:00
baldurk 4dbcfca343 Fix reflection of structs containing 16-bit types. Closes #3605
* It is impossible to emit a true 16-bit type on fxc, the minXX types we round
  up internally to a 32-bit type since that's how they are defined to appear in
  external resources like cbuffers and SRV/UAVs.
* The new 16-bit type enums that are shared between fxc/dxc structs are not
  actually ever emitted by fxc for RDEF types.
2025-05-05 14:49:24 +01:00
baldurk 62be3340a5 Check more carefully if DX11 maps are intercepted properly. Closes #3603
* Maps are recorded as open whenever we intercept them, usually only falling off
  for high traffic resources or direct maps like WRITE_NO_OVERWRITE.
* Unmaps can be successful any time as long as they're intercepted as reads (no-
  op) or write discard (since we just need to intercept these).
* Unmaps from other write types require a map during an active capture to ensure
  we properly set up shadow pointers.
2025-05-05 12:42:28 +01:00
baldurk 2288237723 Early detect and error when launching reserved filenames for capture
* This is a safety measure to ensure we never add hooks to system processes, so
  we should detect this case earlier and error for the user.
2025-05-05 10:49:42 +01:00
baldurk 9673a5571c Don't silently drop working directory, print error if it doesn't exist 2025-05-05 10:49:01 +01:00
baldurk f9c1ae7944 Fix installer script referencing missing entry 2025-05-03 22:03:21 +01:00
Camden Mannett 7a551bcfc2 Add AS descriptor handling in vkCmdPushDescriptorSetKHR
Closes #3598
2025-05-03 15:45:49 +01:00
baldurk bb10ae25bb Bump version to v1.39 2025-05-02 15:07:38 +01:00
baldurk 34c3c40787 Document the PDB search priority/algorithm
* This follows PIX's algorithm in most places which although undocumented is
  something many people expect to work. It deviates only when there would be
  significant performance penalties for little gain.
v1.38
2025-05-02 10:48:10 +01:00
baldurk a8a14bc317 When possible reject aliased pdb names using HASH 2025-05-01 15:40:23 +01:00
baldurk f5506fcec3 Workaround of pixel history crash with depth-only UAV writes 2025-05-01 10:36:07 +01:00
Jake Turner df08881ef2 Add asserts to check for out of bounds GSM variable access 2025-04-30 11:59:03 +01:00
Jake Turner 35f91b2575 Compute GSM raw variable declaration element count from byte count 2025-04-30 11:59:03 +01:00
Jake Turner cf879397bd Fix incorrect indexing when getting GSM Register Index 2025-04-30 11:59:02 +01:00
baldurk 852825c6f1 Remove 32-bit GPA from installer manifest 2025-04-30 11:50:55 +01:00
Cam Mannett 47ee186e65 Retain initial contents type on softmem flush reset
Otherwise resources are filtered out before writing.

Change-Id: I76e096472aa3a8b32b81ccd4612da7330173ed47
2025-04-29 15:50:02 +01:00
baldurk 36e53ae0cd Ensure color format is always set for GL pixel history framebuffers 2025-04-29 12:09:51 +01:00
baldurk 8e86f79c72 Fix compiling pixel history shaders on GLES breaking 2025-04-29 12:09:38 +01:00
baldurk 395d8079e6 Don't test MSAA with A8_UNORM formats in VK_Texture_Zoo
* This is apparently in a format capability class to R8 it seems, and since we
  don't expect anyone to be rendering to A8 let alone in MSAA, there's no point
  in testing this.
2025-04-28 17:26:53 +01:00
baldurk d239a59ff0 Fix pick component type for S8 textures 2025-04-28 17:26:06 +01:00
baldurk 361624ff84 Add slight increase to error tolerance for SNorm textures 2025-04-28 17:10:53 +01:00
baldurk 6ded6187dc Update python example code using old API member 2025-04-28 11:34:18 +01:00
baldurk ade38c43d4 Only apply dynamic offsets for the relevant pipeline type 2025-04-24 16:12:15 +01:00
baldurk 5b5bec6334 Handle forward referenced function members in debuginfo types 2025-04-24 16:12:15 +01:00
baldurk e0b0b24efd Increase shader compiler delay in tests 2025-04-24 16:12:15 +01:00
Le Philousophe bf1ebeeb86 Allow custom visualisation shaders to be used with GLES
With GLES, a precision specifier is mandatory for float types.
Specifying one in the user shader is not enough because it happens too
late after uvec2 and uvec4 uses in the custom prefix.
2025-04-24 12:02:24 +01:00
baldurk e03ea6b040 Fix incorrect log print 2025-04-23 10:53:50 +01:00
baldurk 4dfedae094 Make sure that const pNext chains aren't modified during patching
* Even if we duplicate the base structure it is not safe to modify the const
  pNext chain without copying it too.
2025-04-23 10:53:50 +01:00
Jake Turner 258ab5b6e3 Change test helper to just check for asserts (not errors)
Setting the Vulkan layer produces two errors
2025-04-22 14:31:43 +01:00
Jake Turner a8de121cd0 Check for Asserts & Errors when running D3D12_Shader_DebugData_Zoo tests 2025-04-22 13:09:04 +01:00
Jake Turner 498e767272 DXBC debugger clamp out of bounds component count to maximum of four 2025-04-22 12:38:27 +01:00
Jake Turner 4ead1e4423 Handle initialising a DXIL constant struct to NULL
It is a nop because ShaderVariable starts initialised to 0
2025-04-22 12:37:28 +01:00
Jake Turner eeac056816 VK and D3D12 Workgroup & Subgroup Zoo tests fail on Asserts or Errors
Check the renderdoc log for lines matching "Assertion" or "Error"
Using new helper function in testcase.py
def check_renderdoc_log(self, asserts: bool = True, errors: bool = True):
2025-04-22 12:33:56 +01:00
Jake Turner 1c4520534d new helper function in testcase.py to check RD log for Asserts/Errors
def check_renderdoc_log(self, asserts: bool = True, errors: bool = True):
2025-04-22 12:33:50 +01:00
Jake Turner 261f957d5b SPIRV workgroup debugger, add padding lanes to align to subgroup size 2025-04-18 13:58:10 +01:00
Jake Turner 5f00ed9d39 SPIRV Debugger workgroup debugging fixes
Set the thread property SubgroupId for the extra lanes outside of the subgroup
pass the workgroup laneIndex to BeginDebug
Set the thread property GroupThreadIndex, GroupFlatIndex for all workgroup lanes
2025-04-18 13:58:10 +01:00
Jake Turner c1fb809f17 SPIRV Debugger, add asserts to ensure the lane index is in range
Specifically when computing the active lanes from the activeMask array
2025-04-18 13:58:09 +01:00
Jake Turner f5222ed547 DXIL Debugger tweak subgroup active lanes helper
add asserts to ensure the lane index is in range
return the first lane in the subgroup
2025-04-18 13:58:09 +01:00
Jake Turner ede0c1d0ee D3D12 Workgroup debugger, add padding lanes to align to subgroup size 2025-04-18 13:58:09 +01:00
Jake Turner 53ad61b6a5 D3D12 Workgroup debugger, use SV_GroupThreadID for threadid
Use SV_GroupThreadID to fill in threadid in the compute fetcher instead of SV_DispatchThreadID
Keep SV_DispatchThreadID to identify the candidate thread
2025-04-18 13:58:09 +01:00
Jake Turner e14bc98e18 Added VK_Workgroup_Zoo, D3D12_Workgroup_Zoo tests
Tests specifically aimed at workgroup debugging i.e GSM and non-aligned subgroups
Not focused on unit tests of subgroup/quad instructions that is handled by *_Subgroup_Zoo
2025-04-18 13:58:09 +01:00
baldurk a8a0e9628d Update VK_CBuffer_Zoo test to account for glslang regression
* glslang now requires and uses scalar block layout for hlsl cbuffer packing
2025-04-18 13:28:19 +01:00
baldurk f837af3066 Make sure functional test sections always match begin/end 2025-04-18 12:54:53 +01:00
baldurk eb05d1b0a6 Fix forced references failing on ASs 2025-04-18 11:20:04 +01:00
baldurk 3b29508f2f Fix vulkan structured data conversion 2025-04-18 11:19:47 +01:00
baldurk 933a91e47c Update shaderc build script (VS2015 no longer supported) 2025-04-18 11:19:34 +01:00
baldurk e1dd947e1e work around compile error asserting on static const 2025-04-17 17:16:50 +01:00
baldurk 506d6c6d7b Fix self-capture for vulkan captures using ASs
* The problem here is that due to design flaws in the extension when ASs are in
  use we don't know whether a memory allocation will need BDA or not an the
  application doesn't have to set any flag - unlike for normal buffer BDA. So we
  promote (almost) all memory allocations to BDA when using ASs even if they're
  not needed.
* This normally works fine except if during self-capture the replay process
  allocates some normal memory before all application replayed allocations have
  been made, the self-capturing will promote it to BDA and request a replayable
  address that might clash with a later address the application had used and
  would be needed.
* To solve this, we ensure that during capture we don't create wrapped
  allocations more than necessary - to avoid causing clashes - as well as
  ensuring that on replay we only create new allocations after all replayed
  allocations.
* We also take advantage of dedicated allocations for fake swapchain images,
  since dedicated image allocations will not be promoted to BDA.
2025-04-17 16:21:19 +01:00